Refactor texture management #2431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajtribick
force-pushed
the
texmanager
branch
4 times, most recently
from
6d05aeb to
a33d22b
Compare
Collaborator
|
It's a big change to go through right now, does it fix #649? |
Collaborator
Author
|
Just checked, yes it does fix that issue. Might be easier to do #2422 first, then I can rebase this one to have only the texture manager changes. |
Collaborator
Author
|
Need to fix some issues in #2422 |
- Results in a cleaner API with more explicit allocation semantics - Remove comparator in mesh sort API: always uses opacity comparison
- Replace singleton texture manager with instance classes - Split path and OpenGL objects handling into TexturePaths and TextureManager - Resolve all resolution paths at the time of creating the handle - Remove MultiTexture class - resolution selection done in TextureManager - Changing resolution or destroying Renderer destroys all loaded GPU textures
|
Collaborator
Author
|
Issue mentioned in #2439 is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #2421 but for textures. Includes changes from #2422
MultiResTexturegoes away and is replaced by a single integer (actually enum class)TextureHandle- resolution selection is now done byTextureManager. Changing resolution results in unloading of GPU textures. Paths to all resolutions are resolved at the time of creation of a newTextureHandle.Note that ring shadow textures are loaded at a maximum of medium resolution, so there is some additional handling of that. On the other hand, unlike meshes the image data is not queried once it goes to the GPU (for meshes the CPU-side data is used for testing object selections), so there is only one
TextureManagerclass instead of aTextureManager/RenderTextureManagersplit.Fixes #649