[ENG-8026] Reference LINK addon implementation: Zenodo #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
changed the title
cslzchen
changed the title
cslzchen
requested changes
May 16, 2025
There was a problem hiding this comment.
In addition to my comments, can we add some comments or Docstring in the implementation file addon_imps/link/zenodo.py to info readers of what each class methods do.
Another note, after we feel good with the reference PR, we can close this PR (to get rid of the conversations, JIRA stuff, etc.) and open a new clean PR as the final reference PR.
cslzchen
reviewed
May 23, 2025
There was a problem hiding this comment.
Looks good. Let me make a PR to the feature branch to adjust the order. I won't change the number to avoid migration for now. starting from 103x is good enough for now. If we ever run out of 1001~1029 for other types of addons in the future, we will handle it when it happens.
… by external developers
opaduchak
force-pushed
the
feature/ENG-8026
branch
from
c8caff5 to
b2fd843
Compare
cslzchen
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Reference LINK addon implementation: Zenodo
Ticket
https://openscience.atlassian.net/browse/ENG-8026