Fix PDF export not rendering emoji/symbols (fpdf2 fallback fonts)#124
Open
chentalia317-alt wants to merge 1 commit intoCenterForOpenScience:mainfrom
Open
Fix PDF export not rendering emoji/symbols (fpdf2 fallback fonts)#124chentalia317-alt wants to merge 1 commit intoCenterForOpenScience:mainfrom
chentalia317-alt wants to merge 1 commit intoCenterForOpenScience:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
This PR introduces fallback fonts to ensure emoji and symbol characters render properly in exported PDFs.
changes:
NotoEmoji-Regular.ttfandNotoSansSymbols2-Regular.ttfundersrc/osfexport/font/; 2. Registered both fonts inPDF.__init__(formatter.py);<font face="noto-emoji">…</font>before rendering;notes:
Both fonts are distributed under the SIL Open Font License (OFL).
Adds ~1.2 MB to repository size; no visual or behavioral changes for non-emoji text.