-
Notifications
You must be signed in to change notification settings - Fork 351
[ENG-9795] Notification Refactor Phase 2 #11460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cslzchen
wants to merge
138
commits into
develop
Choose a base branch
from
feature/notification-refactor-p2-s
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+15,043
−15,051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: John Tordoff <[email protected]> Co-authored-by: Ostap Zherebetskyi <[email protected]> Co-authored-by: Bohdan Odintsov <[email protected]> Co-authored-by: John Tordoff <>
* Fix moderator digest * Fix unit tests
…ion (#11324) * Fix issue with user confirmation/merger creating subscription * Add docstrings
* Add No Login to notification template and add to tests
…tion-refactor-p2-s * Conflicts have not been resolved in this merge since we want to track how we fixed the conflicts due to complexity * api/nodes/serializers.py * osf/models/user.py * tests/test_auth.py * tests/test_webtests.py * website/templates/node_request_institutional_access_request.html.mako
…plate-with-naming [ENG-8988] Fix/notification contrib template with naming
[ENG-8997] Turn on script tests
[ENG-8996] Fix moderator added template
[ENG-9005] Fix/update v2 subscriptions
…tests [ENG-9603] Fix Reset Password Tests
…om/centerforopenscience/osf.io into fix-test-add-contributors-notifications
…-notifications [ENG-9600][ENG-9606] Notification refactor fix contributor adding issues
…om/centerforopenscience/osf.io into fix-institutional-request-templates
…-templates [ENG-9605] Fix institutional node request updates template
[ENG-9670] Moderator Notifications: Moderator added email notifications doesn't include any links to provider
[ENG-9672] fix notifications logo
[ENG-9672] use server dependent domain instead of hard-coded production URL
…_type_word [ENG-9670] update notification settings URL and provider URL based on provider type
…-links [ENG-9675] Fix collection submission links
…ttings [ENG-9758] User settings notification choices don't persist
…ure/notification-refactor-p2-s-revert [ENG-9766] Revert "Revert "revert push to develop""
…ttings [ENG-9758] User settings notification choices don't persist
…ttings [ENG-9758] fix NotificationSubscription _id property
…tions [ENG-9762] [ENG-9758] Refactor notification subscriptions and digest handling
…nged_email [ENG-9796] Update project affiliation changed email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Notification Refactor Phase 2 Project PR for CR
Ticket
https://openscience.atlassian.net/browse/ENG-9795