Skip to content

Feature/custom detectors api - #833

Open
Luchistack wants to merge 3 commits into
Centurylong:mainfrom
Luchistack:feature/custom-detectors-api
Open

Feature/custom detectors api#833
Luchistack wants to merge 3 commits into
Centurylong:mainfrom
Luchistack:feature/custom-detectors-api

Conversation

@Luchistack

Copy link
Copy Markdown
Contributor

#closes #725

Summary of Changes

  • Custom Rules API: Implemented a stable Rule trait and registry module (tooling/sanctifier-core/src/rules/mod.rs) to allow third-party developers to write and register custom static analysis detectors.
  • Example Detector: Added an example NoUnsafeBlockRule detector (tooling/sanctifier-core/src/rules/example.rs) to showcase custom rule authoring for Soroban smart contracts.
  • Documentation: Created comprehensive developer documentation (docs/api/custom-rules.md) outlining the rule-authoring API and registration usage.

Type of Change

  • New feature / extensible API (feat)
  • Documentation update (docs)

Testing & Verification

  • Verified directory creation and file compilation setup.
  • Confirmed correct branch creation, remote configuration, and SSH push.

#closes

CelestinaBeing and others added 3 commits July 22, 2026 13:50
ethnum 1.5.0 (via soroban-env-common 20.3.0) fails on newer rustc with E0512 (transmute size mismatch); no newer ethnum is allowed by the soroban constraint, so pin the toolchain. 1.85.0 is the lowest stable that also satisfies base64ct 1.8.3's edition2024 requirement. Also fix clippy lints newly enforced by 1.85: only_used_in_recursion on the two estimate_type_size methods and collapsible_else_if in analyze.rs.
@github-actions github-actions Bot added rust Pull requests that update rust code area: core-engine sanctifier-core static analysis engine area: docs Documentation and guides size/m labels Jul 22, 2026
@Gbangbolaoluwagbemiga
Gbangbolaoluwagbemiga force-pushed the main branch 2 times, most recently from 32f43f6 to f15d961 Compare July 22, 2026 16:51
@Gbangbolaoluwagbemiga

Copy link
Copy Markdown
Contributor

@Luchistack , ci pipeline failed, please pull from upstream and resolve the ci, a major fix has been commit to the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core-engine sanctifier-core static analysis engine area: docs Documentation and guides rust Pull requests that update rust code size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom-rule authoring API for external contributors

3 participants