Detector: Reentrancy via env.invoke_contract before effects (#793) - #864
Open
odogu01 wants to merge 1 commit into
Open
Detector: Reentrancy via env.invoke_contract before effects (#793)#864odogu01 wants to merge 1 commit into
odogu01 wants to merge 1 commit into
Conversation
…fore state effects Adds a static-analysis detector that flags when env.invoke_contract is called before storage writes (set/update/remove/try_update) in a public contract function, violating the Checks-Effects-Interactions (CEI) pattern. Closes Centurylong#793
github-actions
Bot
added
rust
Contributor
|
@odogu01, please resolve conflicts and make sure all ci passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new static-analysis detector
reentrancy_invoketo flag whenenv.invoke_contractis called before storage effects (writes), violating the Checks-Effects-Interactions (CEI) pattern.Closes #793
Changes
tooling/sanctifier-core/src/rules/reentrancy_invoke.rs— analyzes public contract functions forinvoke_contractcalls that precede storage mutations (set/update/remove/try_update). Skips#[cfg(test)]modules and does not flag when effects already precede the invoke.SANCT_REENTRANCY_INVOKEadded tofinding_codes.rsrules/mod.rsdefault rule setdocs/detectors/reentrancy_invoke.mdwith vulnerable example, fix, and detection techniquedifferential-corpus.jsonupdated with the new rule mappingAcceptance Criteria
invoke_contractbefore effects