Skip to content

Conversation

@Certseeds
Copy link
Owner

No description provided.

@Certseeds Certseeds self-assigned this Oct 18, 2025
@Certseeds Certseeds added the bug Something isn't working label Oct 18, 2025
Copilot AI review requested due to automatic review settings October 18, 2025 11:26
@Certseeds Certseeds merged commit 86d6d16 into master Oct 18, 2025
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where required directories are missing under the third_party folder. The fix extracts the catch2.tar.gz archive to ensure necessary files are present before the script proceeds with its operations.

Key Changes:

  • Adds tar extraction command to unpack catch2.tar.gz into the third_party directory at the beginning of the main function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +4 to +6
tar \
-xzvf third_party/catch2.tar.gz \
-C third_party/
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tar command uses a relative path 'third_party/catch2.tar.gz' which will fail if the script is executed from a different working directory. Since the script already determines its own directory location on line 8, consider moving this tar extraction after the 'self_dir' assignment and using '$self_dir/catch2.tar.gz' instead to ensure the path is always correct regardless of where the script is invoked from.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants