Add mapped raster tiles in the progress percentage. #1305
Add mapped raster tiles in the progress percentage. #1305j9liu merged 8 commits intoCesiumGS:mainfrom
Conversation
…that rely on this progress percentage to continue updating their views until all raster tiles have been properly loaded.
j9liu
left a comment
j9liu
left a comment
There was a problem hiding this comment.
Thanks for the PR @rbois-bentley ! This change makes sense, I just have a few comments.
| for (const Tile::ConstPointer& pTile : updateResult.tilesToRenderThisFrame) { | ||
| const std::vector<RasterMappedTo3DTile>& mappedRasterTiles = | ||
| pTile->getMappedRasterTiles(); | ||
| for (const RasterMappedTo3DTile& mappedRasterTile : mappedRasterTiles) { |
There was a problem hiding this comment.
There's actually a similar loop happening on line 205. To avoid the duplicate passes, can we merge this logic into that loop below? (We may have to shift around other lines to compute the percentage at the very end, but that's fine.)
There was a problem hiding this comment.
@j9liu Thanks for the review, I'll look into merging the logic...
|
@rbois-bentley Just checking in, is this ready for another look? |
@j9liu Yes, it's ready. Thanks! |
j9liu
left a comment
j9liu
left a comment
There was a problem hiding this comment.
Thanks @rbois-bentley ! Changes look great, I'm just doing some last tests in Unreal before merging to make sure things behave as expected.
2 participants
This allows apps that rely on this progress percentage to continue updating their views until all raster tiles have been properly loaded.