Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is purely for discussion and collaboration related to #979. My hope is to get feedback and iterate on what a polyglot implementation might look like. For this first iteration, I replaced
async++with a Rust backed async crate exposed by the C FFI. The hope is that this repo gains the memory safety of Rust, while also beginning a larger effort to expose this libraries excellent algorithms to other languages.Issue number or link
See #979
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Remaining Tasks
Yes, I would like feedback on what the community thinks of this approach. I would like to iterate and improve on the currnt implementation, and again would apprecate feedback on this.
Testing plan
This merely replaced the backend to
CesiumAsync. Tests were added, but alle existing tests also test this change.Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.