-
Notifications
You must be signed in to change notification settings - Fork 264
geoJSON tilesets with glTF translation #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timoore
wants to merge
41
commits into
main
Choose a base branch
from
tileset-geojson2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 35 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
3bead27
Support MAXAR_content_geojson in tilesets
timoore adb705f
Call prepareInLoadThread() for tiles with feature content
timoore 4806a06
Add test for loading GeoJson
timoore eadf0cb
Add include files for clang-tidy's benefit
timoore 9c6a8fc
Documentation fixes
timoore c88bd5f
More documentation fixes
timoore e0c1e1c
Merge branch 'main' into tileset-geojson
timoore d4873ba
Early work on GeoJson tilesets with glTF translation
timoore c3d39d8
Get it to compile
timoore b230b40
process GeoJson line strings
timoore 72027d0
Add conversion of GeoJson Polygon and MultiPolygon features
timoore 2c809dd
Early work on GeoJson tilesets with glTF translation
timoore e29b691
Get it to compile
timoore 16ba9fd
process GeoJson line strings
timoore fc6271c
Add conversion of GeoJson Polygon and MultiPolygon features
timoore 4d8a2c8
Merge branch 'tileset-geojson2' into geojsontogltf
timoore c618027
Fixup from merge
timoore b0e5e52
Make root tile of EllipsoidTileset have a bounding box
timoore 208ad09
Fix error in translateGltf option logic
timoore 7042520
fixup for clang-format
timoore 2084113
Make clang-tidy happy
timoore 172fee0
Set accessor min and max, assuage clang-tidy
timoore a772d41
more clang-tidy
timoore 1b50ce3
Gather GeoJson point data
timoore 0f6e40d
clang-format
timoore 2aa9c92
Documentation
timoore fa36156
format the documentation
timoore beb403d
Clean up iteration
timoore c6e8e9c
Clean up glTF construction and fix bugs
timoore df2caed
include Mesh.h for clang-tidy
timoore b3dafc2
Add an obnoxious color to the feature material, for debugging
timoore deabec6
more while loop -> for loop cleanup
timoore 5155010
Change to using a local class for doing the conversion
timoore 26bb57a
Change from operator() method to convert()
timoore d0f71f1
Use helper functions to remove redundant code
timoore f2d7c69
Fix clang-tidy complaints
timoore 3790b84
Don't use static_cast for integer casts
timoore 6bc96e1
Use BoundingRegionBuilder to find coordinate "centroid"
timoore ffbd51e
clang-format and clang-tidy strike again
timoore 7f68b73
Remove translateVectorFeaturesOptions
timoore b009a33
more cleanup from PR review
timoore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #pragma once | ||
|
|
||
| #include <CesiumGltf/Model.h> | ||
| #include <CesiumVectorData/GeoJsonDocument.h> | ||
|
|
||
| namespace CesiumVectorData { | ||
|
|
||
| /** | ||
| * @brief The result of converting a GeoJSON file to a glTF model. | ||
| */ | ||
| struct CESIUMVECTORDATA_API ConverterResult { | ||
|
timoore marked this conversation as resolved.
Outdated
|
||
| /** | ||
| * @brief The gltf model converted from GeoJSON. This is empty if | ||
| * there are errors during the conversion | ||
| */ | ||
| std::optional<CesiumGltf::Model> model; | ||
|
|
||
| /** | ||
| * @brief The error and warning list when converting to a gltf | ||
| * model. This is empty if there are no errors during the conversion | ||
| */ | ||
| CesiumUtility::ErrorList errors; | ||
| }; | ||
|
|
||
| /** | ||
| * @brief Functional for converting GeoJSON documents to glTF. | ||
| */ | ||
| class CESIUMVECTORDATA_API GltfConverter { | ||
| public: | ||
| /** | ||
| * @brief Convert geoJSON document to a result which includes a glTF Model | ||
| * object. | ||
| * | ||
| * @param geoJson The GeoJSON document. | ||
| * @returns A result object that includes the glTF Model and any errors. | ||
| */ | ||
| static ConverterResult convert(const GeoJsonDocument& geoJson); | ||
| }; | ||
| } // namespace CesiumVectorData | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.