Skip to content

Fix updateViewGroupOffline() so that it doesn't hang #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j9liu merged 2 commits into from
Mar 31, 2026
+13 −0
Merged

Fix updateViewGroupOffline() so that it doesn't hang #1336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8193004
Fix updateViewGroupOffline so that it doesn't hang
ELeeScape Mar 30, 2026
e227a5f
format
ELeeScape Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cesium3DTilesSelection/src/Tileset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,16 +333,19 @@ const ViewUpdateResult& Tileset::updateViewGroupOffline(

// TODO: fix the fading for offline case
// (https://github.com/CesiumGS/cesium-native/issues/549)
this->_asyncSystem.dispatchMainThreadTasks();
this->updateViewGroup(viewGroup, frustums, 0.0f);
while (viewGroup.getPreviousLoadProgressPercentage() < 100.0f) {
this->_externals.pAssetAccessor->tick();
this->_asyncSystem.dispatchMainThreadTasks();
this->loadTiles();

// If there are no frustums, we'll never make any progress. So break here to
// avoid getting stuck in an endless loop.
if (frustums.empty())
break;

this->_asyncSystem.dispatchMainThreadTasks();
this->updateViewGroup(viewGroup, frustums, 0.0f);
}

Expand Down Expand Up @@ -371,9 +374,12 @@ const ViewUpdateResult& Tileset::updateViewGroupOffline(
}

const ViewUpdateResult&

Tileset::updateView(const std::vector<ViewState>& frustums, float deltaTime) {
this->_asyncSystem.dispatchMainThreadTasks();
const ViewUpdateResult& result =
this->updateViewGroup(this->_defaultViewGroup, frustums, deltaTime);
this->_asyncSystem.dispatchMainThreadTasks();
this->loadTiles();
return result;
}
Expand Down
8 changes: 8 additions & 0 deletions Cesium3DTilesSelection/test/TestTilesetSelectionAlgorithm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,14 @@ TEST_CASE("Test replace refinement for render") {
}
}


SUBCASE(
"updateViewGroupOffline does its own dispatching of main thread tasks "
" so it doesn't get stuck") {
ViewState viewState = zoomToTileset(tileset);
tileset.updateViewGroupOffline(tileset.getDefaultViewGroup(), {viewState});
}

SUBCASE(
"updateViewGroupOffline does not get stuck in an endless loop when no "
"frustums are given") {
Expand Down
Loading