Skip to content

Support for CesiumVectorOverlays::VectorTilesRasterOverlay#1845

Merged
j9liu merged 7 commits into
mainfrom
vector-tiles-overlay
May 28, 2026
Merged

Support for CesiumVectorOverlays::VectorTilesRasterOverlay#1845
j9liu merged 7 commits into
mainfrom
vector-tiles-overlay

Conversation

@azrogers

Copy link
Copy Markdown
Contributor

Depends on CesiumGS/cesium-native#1365. This PR adds support for the new VectorTilesRasterOverlay to allow vector 3D Tiles tilesets to be draped over other tilesets. It also in the process adds support for displaying points from GeoJSON documents. Because the vector tiles PR moved the GeoJSON overlay to the new CesiumVectorOverlays namespace, this PR also applies that change here.

@j9liu j9liu added this to the June 2026 Release milestone May 26, 2026
@j9liu j9liu self-requested a review May 26, 2026 15:14

@j9liu j9liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @azrogers for the PR! I still have to finish the cesium-native PR review and run some test data through this, but just wanted to leave the few small comments I had so far.

Comment thread Source/CesiumRuntime/Public/CesiumVectorStyle.h Outdated
Comment thread Source/CesiumRuntime/Private/CesiumVectorTilesRasterOverlay.cpp
Comment thread Source/CesiumRuntime/Private/CesiumVectorStyle.cpp Outdated
Comment thread Source/CesiumRuntime/Public/CesiumVectorTilesRasterOverlay.h
@j9liu

j9liu commented May 26, 2026

Copy link
Copy Markdown
Contributor

Something else I found... the Unreal Editor unfortunately gets stuck on quit when a vector overlay is in the scene because IsReadyForFinishDestroy never resolves to true. It seems like the async destruction event is never called, maybe something is stuck or not properly destroyed?

@azrogers

Copy link
Copy Markdown
Contributor Author

@j9liu Looks like the problem was I set the destructor of VectorTilesRasterOverlay to default when it's the destructor that resolves the promise... should be fixed now. Also, had to fix the CI that broke due to the linux image changing.

@j9liu j9liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @azrogers!

I'm just doing a fresh build to verify that the destructor is working properly, but if all goes well, this should be good to merge.

@j9liu j9liu merged commit 5bca73f into main May 28, 2026
45 of 46 checks passed
@j9liu j9liu deleted the vector-tiles-overlay branch May 28, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants