Fix availability check in VoxelTraversal for procedural tilesets #12458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small bug introduced in #12430 affecting procedural tilesets.
The
requestData
helper function inVoxelTraversal
included a check ofprovider._implicitTileset.availableLevels
to avoid generating spurioustileFailed
events. However, custom procedural providers (as used in some of our sandcastle examples) do not have an._implicitTileset
.This PR adds a public
availableLevels
property toVoxelProvider
, which is allowed to be undefined.VoxelTraversal
now verifies the property is defined before checking its value.Issue number and link
Testing plan
Load the "Voxels" Sandcastle and verify that all datasets render without errors.
Author checklist
CONTRIBUTORS.md
[ ] I have updatedFixes a bug not present in the previous releaseCHANGES.md
with a short summary of my change