Fix jittering artifacts with primitives on Intel Arc GPUs #13096
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @kring! ✅ We can confirm we have a CLA on file for you. |
mzschwartz5
reviewed
Dec 19, 2025
Contributor
There was a problem hiding this comment.
Hey Kevin,
Thanks for the detailed investigation - it was a good read. Two thoughts:
- I don't know how
mixis implemented under the hood, but I wonder if it would help the precision issues to do it manually asa*(1-t) + b*t(if, internally, it's implemented asa + t*(b - a), and a and b are large, I could see that causing precision issues). - If that doesn't help, can we at least leave an in-code comment explaining why it's necessary to branch at all here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12879
Lots of background details here:
#12879 (comment)
Draft because this is only going to work on WebGL2. It's mostly a proof-of-concept.