Fixed inconsistent typescript types between InterpolationAlgorithm and its implementations#13645
Open
jfayot wants to merge 3 commits into
Open
Fixed inconsistent typescript types between InterpolationAlgorithm and its implementations#13645jfayot wants to merge 3 commits into
jfayot wants to merge 3 commits into
Conversation
…hm interface and its 3 implementations
Contributor
|
Thank you for the pull request, @jfayot! ✅ We can confirm we have a CLA on file for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes inconsistent generated typescript types between
InterpolationAlgorithmand its Hermite, Lagrange, and Linear implementations.SampledPositionProperty.setInterpolationOptionsexpects anInterpolationAlgorithm, but the generated declarations did not correctly represent the implementations:typewas not emitted when declared only within the namespace object literal.interpolatewas emitted as required even though only Hermite supports it.This PR:
typeproperty explicitly so it is included in generated declarations@optionaltagInterpolationAlgorithm.interpolateas optional but preserves its API documentationSampledPositionProperty.setInterpolationOptionsThe generated interface now correctly includes:
Issue number and link
Fixes: #13644
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment