-
Notifications
You must be signed in to change notification settings - Fork 9
Draft extension for SPZ compression support for Gaussian splats #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Adam Morris <[email protected]>
Co-authored-by: Adam Morris <[email protected]>
…e extension rather than building on KHR_gaussian_splatting
lilleyse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Just a few comments from me.
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
...ian_splats_compression/schema/mesh.primitive.KHR_spz_gaussian_splats_compression.schema.json
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
…DME.md Co-authored-by: Sean Lilley <[email protected]>
…DME.md Co-authored-by: Sean Lilley <[email protected]>
…DME.md Co-authored-by: Sean Lilley <[email protected]>
…DME.md Co-authored-by: Sean Lilley <[email protected]>
|
I did something I shouldn't have and managed to completely pollute the history for this branch. I will try to clean it up later. @lilleyse - when you have a moment another review pass is appreciated. |
| "max": [ | ||
| 1, | ||
| 1, | ||
| 1, | ||
| ], | ||
| "min": [ | ||
| -1, | ||
| -1, | ||
| -1, | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required by the glTF spec for all POSITION accessors.
In reality, we should probably calculate the actual bounds, but right now this is good enough since we don't need them for implementation.
A good ask for the working group is if we can relax this requirement when our extension is in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good ask for the working group is if we can relax this requirement when our extension is in use.
I changed my mind about this. I think there's still potential for these bounds to be very useful in some engines. We should still require these bounds to be properly calculated.
|
I was able to fix the history by
Though none of this will matter once a PR is opened in the Khronos repo (at least I don't see the need to keep the commit history) |
lilleyse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments from me. I like how simple the extension schema is now.
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Lilley <[email protected]>
Co-authored-by: Sean Lilley <[email protected]>
|
I'm going to close this PR and create a new branch cherry picked from this one. While Sean fixed the issue for our review purposes, my mishap still creates quite a mess for a PR into the official glTF repo. |
|
Reopened in the Khronos Group glTF repo: KhronosGroup#2490 |
|
GISBox now fully supports the KHR_spz_gaussian_splats_compression slicing function. This feature, through an innovative slicing compression algorithm, significantly improves the transmission efficiency and rendering performance of Gaussian splatting point cloud data. |
Follows EXT_draco_mesh_compression as pattern.