-
Notifications
You must be signed in to change notification settings - Fork 73
update syntax and example after 5792 syntax changes #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bumblefudge
wants to merge
10
commits into
main
Choose a base branch
from
feat/update-eip155-caip25-guidance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−28
Open
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
31c7e0a
update syntax and example after 5792 syntax changes
bumblefudge 37dc500
update example per ReOwn input
bumblefudge 37b91a3
good catch llbartekll
bumblefudge 482f615
add atomic cap equivalent to new example added by erc#9529
bumblefudge a2967fb
good catch llbartekll
bumblefudge 333a477
make response example slightly clearer
bumblefudge 357fa87
match most recent syntax change on 5792
bumblefudge 4bb0801
include every variation on getCapabilities objects and add inline com…
bumblefudge 848dc26
finesse spec text to match new exhaustive example re: 5792 capabilities
bumblefudge b43ffb5
update atomic syntax to most recent PR on 5792
bumblefudge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I'm realizing that my gut feeling is that
sessionProperties
should be reserved for properties that live fully outside of any given namespace and thatscopedProperties
should allow you to map things to a namespace or a full CAIP-2 chainId scope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i feel you, but full CAIP-2 scopes are out, remember? hehe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in what context? They're clearly still the keys in
scopedProperties
?