Closed
Conversation
nazarhussain
requested changes
Mar 4, 2026
nazarhussain
left a comment
There was a problem hiding this comment.
Initiating main thread work, before spawning workers enforces that main thread work is finished before child threads started, defeats parallelism.
Comment on lines
+128
to
+133
| // Main thread does worker 0's work | ||
| workerFn(&contexts[0]); | ||
| for (0..n_workers - 1) |t| { | ||
| threads[t] = std.Thread.spawn(.{}, workerFn, .{&contexts[t + 1]}) catch return BlstError.VerifyFail; | ||
| spawned += 1; | ||
| } |
There was a problem hiding this comment.
Suggested change
| // Main thread does worker 0's work | |
| workerFn(&contexts[0]); | |
| for (0..n_workers - 1) |t| { | |
| threads[t] = std.Thread.spawn(.{}, workerFn, .{&contexts[t + 1]}) catch return BlstError.VerifyFail; | |
| spawned += 1; | |
| } | |
| for (0..n_workers - 1) |t| { | |
| threads[t] = std.Thread.spawn(.{}, workerFn, .{&contexts[t + 1]}) catch return BlstError.VerifyFail; | |
| spawned += 1; | |
| } | |
| // Main thread does worker 0's work in parallel with spawned threads | |
| workerFn(&contexts[0]); |
dcc1aa0 to
19033cf
Compare
Open
40ba6ed to
a809483
Compare
Contributor
Author
|
closing this in favour of ChainSafe/lodestar-z#231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make verification of multiple aggregate signatures multithreaded above a certain number of elements.