Skip to content

Fix Filecoin.ChainGetEvents method#5593

Merged
elmattic merged 4 commits intomainfrom
elmattic/fix-chain-get-events
Apr 23, 2025
Merged

Fix Filecoin.ChainGetEvents method#5593
elmattic merged 4 commits intomainfrom
elmattic/fix-chain-get-events

Conversation

@elmattic
Copy link
Copy Markdown
Contributor

@elmattic elmattic commented Apr 22, 2025

Summary of changes

Changes introduced in this pull request:

  • Fix apply_block_messages function
  • Remove RPC method from filter lists
forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http forest_snapshot_calibnet_2025-04-22_height_2599416.forest.car.zst --filter ChainGetEvents -n 200
| RPC Method                    | Forest | Lotus |
|-------------------------------|--------|-------|
| Filecoin.ChainGetEvents (254) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #5579

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic requested a review from a team as a code owner April 22, 2025 16:24
@elmattic elmattic requested review from LesnyRumcajs and hanabi1224 and removed request for a team April 22, 2025 16:24
@LesnyRumcajs
Copy link
Copy Markdown
Member

Can we add an RPC snapshot for regression testing?

@elmattic
Copy link
Copy Markdown
Contributor Author

Can we add an RPC snapshot for regression testing?

Sure, but this will be done in a following PR once #5585 is implemented.

@LesnyRumcajs
Copy link
Copy Markdown
Member

no green checkmark!

@elmattic elmattic added the RPC requires calibnet RPC checks to run on CI label Apr 22, 2025
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's add a changelog entry.

@elmattic
Copy link
Copy Markdown
Contributor Author

LGTM, let's add a changelog entry.

No need. There is already one in Forest unreleased section:

Add support for Filecoin.ChainGetEvents RPC method

@elmattic elmattic added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit adbdf28 Apr 23, 2025
35 of 55 checks passed
@elmattic elmattic deleted the elmattic/fix-chain-get-events branch April 23, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filecoin.ChainGetEvents response mismatch

3 participants