Merged
Conversation
Contributor
WalkthroughThis PR updates Go module dependencies across three Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies" Comment |
hanabi1224
requested review from
akaladarshi and
sudo-shashank
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
f3-sidecar/go.mod (1)
14-15: Note potential cross-repository compatibility concerns with lotus.The linked repository
filecoin-project/lotususes overlapping libp2p dependencies. Based on the linked findings:
- lotus imports
github.com/libp2p/go-libp2pandgithub.com/libp2p/go-libp2p-kad-dhtextensively across networking, pubsub, and DHT modules- lotus go.mod shows go-libp2p v0.47.0 and kad-dht v0.38.0
This Forest PR updates to go-libp2p v0.48.0, which differs from lotus's v0.47.0. If Forest and lotus interact at the networking layer, version mismatches could cause:
- Protocol incompatibilities
- DHT routing issues
- Pubsub message handling differences
Please verify that these version differences are acceptable for the integration between Forest and lotus, especially for F3 consensus communication.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@f3-sidecar/go.mod` around lines 14 - 15, The go.mod bumps github.com/libp2p/go-libp2p to v0.48.0 (while lotus uses v0.47.0 for go-libp2p and v0.38.0 for go-libp2p-kad-dht), which may introduce cross-repo compatibility issues; confirm compatibility by either pinning go-libp2p to v0.47.0 to match lotus or explicitly validating v0.48.0: review the libp2p and kad-dht changelogs for breaking changes, run end-to-end networking/DHT/pubsub integration tests between Forest (F3) and lotus, and if any incompatibility appears, adjust the dependency in go.mod (github.com/libp2p/go-libp2p and github.com/libp2p/go-libp2p-kad-dht) to the compatible version or add module replacement rules to enforce a compatible set.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@f3-sidecar/go.mod`:
- Around line 49-50: Update code to handle boxo v0.37.0 breaking changes: search
for any gateway/content-negotiation code and ensure the new “?format=” override
behavior is correct; if you rely on automatic codec conversions enable
Config.AllowCodecConversion=true where codec conversions were previously
implicit; replace any Zipkin tracing exporter usage with OTLP-compatible code
paths or route Zipkin to OTLP ingestion; review any UnixFS HAMT sharding setup
and adjust HAMTShardingSize to account for the threshold change (>= → >); audit
uses of chunker.DefaultBlockSize (now a var and 2MiB max) and adjust chunker
configuration if you depended on the old 1MiB constant; finally run
unit/integration tests and validate OpenTelemetry and Pion WebRTC compatibility
(OTel v1.42.0 and Pion v4.2.9) and update go.mod/go.sum accordingly.
---
Nitpick comments:
In `@f3-sidecar/go.mod`:
- Around line 14-15: The go.mod bumps github.com/libp2p/go-libp2p to v0.48.0
(while lotus uses v0.47.0 for go-libp2p and v0.38.0 for go-libp2p-kad-dht),
which may introduce cross-repo compatibility issues; confirm compatibility by
either pinning go-libp2p to v0.47.0 to match lotus or explicitly validating
v0.48.0: review the libp2p and kad-dht changelogs for breaking changes, run
end-to-end networking/DHT/pubsub integration tests between Forest (F3) and
lotus, and if any incompatibility appears, adjust the dependency in go.mod
(github.com/libp2p/go-libp2p and github.com/libp2p/go-libp2p-kad-dht) to the
compatible version or add module replacement rules to enforce a compatible set.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b87e57db-092b-47a5-a1f5-8c5ab42c41e0
⛔ Files ignored due to path filters (3)
f3-sidecar/go.sumis excluded by!**/*.suminterop-tests/src/tests/go_app/go.sumis excluded by!**/*.sumtools/prometheus_metrics_validator/go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
f3-sidecar/go.modinterop-tests/src/tests/go_app/go.modtools/prometheus_metrics_validator/go.mod
akaladarshi
approved these changes
Mar 18, 2026
Contributor
Author
|
@coderabbitai create 3 issues to track the implementation of https://github.com/filecoin-project/FIPs/blob/master/FRCs/frc-0089.md, porting filecoin-project/lotus#12093 and porting filecoin-project/lotus#13547 |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainLet me first gather details about all three items so I can create meaningful issue titles and descriptions. Now let me fetch the Lotus PR details. 🏁 Script executed: Length of output: 3 Let me fetch the PR details via web search. Let me fetch the Lotus PR details directly via the GitHub REST API. 🏁 Script executed: Length of output: 1565 Now I have all the details. Let me create the 3 issues. 🏁 Script executed: Length of output: 235
Issue 1 — Implement FRC-0089 EC finality calculatorTitle: Body: ## Overview
Implement the EC (Expected Consensus) finality calculator as specified in [FRC-0089](https://github.com/filecoin-project/FIPs/blob/master/FRCs/frc-0089.md).
## Background
FRC-0089 proposes a dynamic finality calculator for Filecoin that considers observed chain history to attain finality guarantees more efficiently than the current static 900-epoch threshold. The calculator can achieve a 2^{-30} error probability in approximately 30 epochs (~15 minutes), a ~30x improvement over the current approach.
## References
- FRC-0089 spec: https://github.com/filecoin-project/FIPs/blob/master/FRCs/frc-0089.md
- Reference implementation: https://github.com/consensus-shipyard/ec-finality-calculator
## Related
- Raised during review of https://github.com/ChainSafe/forest/pull/6757Issue 2 — Port Lotus
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
bump go deps to fix https://github.com/ChainSafe/forest/security/dependabot/154 and https://github.com/ChainSafe/forest/security/dependabot/155
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit