Skip to content

chore: mise insta task for openrpc specs#6806

Merged
LesnyRumcajs merged 1 commit intomainfrom
mise-insta-task
Mar 26, 2026
Merged

chore: mise insta task for openrpc specs#6806
LesnyRumcajs merged 1 commit intomainfrom
mise-insta-task

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Mar 26, 2026

Summary of changes

Changes introduced in this pull request:

  • add a mise insta task to facilitate RPC spec updates

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Documentation

    • Updated release checklist to streamline the RPC specification update workflow by consolidating previously separate command executions into a single unified approach.
  • Chores

    • Added a new automated development task for managing snapshot updates.
    • Implemented version pinning for development tooling to ensure consistent behavior across team environments.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner March 26, 2026 12:27
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team March 26, 2026 12:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Walkthrough

The pull request simplifies the RPC specs snapshot update workflow by introducing a mise insta task in the configuration file that encapsulates the multi-step process, and updates the release checklist to reference this single command.

Changes

Cohort / File(s) Summary
Release Checklist Update
docs/docs/developers/guides/release_checklist.md
Simplified RPC specs update step from multi-command sequence (cargo test --lib -- rpc::tests::openrpc followed by cargo insta review) to single command (mise insta).
Mise Configuration
mise.toml
Added new tasks.insta task that runs the OpenRPC test and accepts snapshots, with explicit tools.cargo-insta = "1.46" version pin.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

RPC

Suggested reviewers

  • hanabi1224
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a mise insta task for openrpc specs management, which is reflected in both the mise.toml and release_checklist.md modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mise-insta-task
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch mise-insta-task

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread mise.toml
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/docs/developers/guides/release_checklist.md (1)

25-25: Add a quick verification note after mise insta in the checklist.

Since this is a release checklist step, add an explicit “review snapshot diff before commit” instruction to prevent accidental snapshot updates.

Suggested wording tweak
-- Make sure to update RPC specs by running `mise insta`
+- Make sure to update RPC specs by running `mise insta`, then review `git diff src/rpc/snapshots` before committing
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/docs/developers/guides/release_checklist.md` at line 25, Update the
checklist line that reads "Make sure to update RPC specs by running `mise
insta`" to append a verification step instructing the releaser to review the
resulting snapshot diff before committing (e.g., "run `mise insta` and review
snapshot diff before commit to avoid accidental snapshot updates"); target the
existing checklist item text and the `mise insta` mention so reviewers can find
and update the exact step.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@mise.toml`:
- Around line 244-245: Replace the non-interactive command "cargo insta accept"
with "cargo insta review" in the test/run command sequence so the RPC snapshot
updates follow the documented interactive review workflow; locate the line
containing the literal "cargo insta accept" in the diff and change it to "cargo
insta review" (ensure the surrounding commands "cargo test --lib --
rpc::tests::openrpc" remain unchanged).

---

Nitpick comments:
In `@docs/docs/developers/guides/release_checklist.md`:
- Line 25: Update the checklist line that reads "Make sure to update RPC specs
by running `mise insta`" to append a verification step instructing the releaser
to review the resulting snapshot diff before committing (e.g., "run `mise insta`
and review snapshot diff before commit to avoid accidental snapshot updates");
target the existing checklist item text and the `mise insta` mention so
reviewers can find and update the exact step.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6b46be59-4bc7-429f-b31c-a35e3dab8bf5

📥 Commits

Reviewing files that changed from the base of the PR and between f9ce8a6 and f918b1b.

📒 Files selected for processing (2)
  • docs/docs/developers/guides/release_checklist.md
  • mise.toml

Comment thread mise.toml
@LesnyRumcajs LesnyRumcajs enabled auto-merge March 26, 2026 13:09
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit bfaf171 Mar 26, 2026
46 of 47 checks passed
@LesnyRumcajs LesnyRumcajs deleted the mise-insta-task branch March 26, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants