chore: mise insta task for openrpc specs#6806
Conversation
WalkthroughThe pull request simplifies the RPC specs snapshot update workflow by introducing a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/docs/developers/guides/release_checklist.md (1)
25-25: Add a quick verification note aftermise instain the checklist.Since this is a release checklist step, add an explicit “review snapshot diff before commit” instruction to prevent accidental snapshot updates.
Suggested wording tweak
-- Make sure to update RPC specs by running `mise insta` +- Make sure to update RPC specs by running `mise insta`, then review `git diff src/rpc/snapshots` before committing🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/docs/developers/guides/release_checklist.md` at line 25, Update the checklist line that reads "Make sure to update RPC specs by running `mise insta`" to append a verification step instructing the releaser to review the resulting snapshot diff before committing (e.g., "run `mise insta` and review snapshot diff before commit to avoid accidental snapshot updates"); target the existing checklist item text and the `mise insta` mention so reviewers can find and update the exact step.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mise.toml`:
- Around line 244-245: Replace the non-interactive command "cargo insta accept"
with "cargo insta review" in the test/run command sequence so the RPC snapshot
updates follow the documented interactive review workflow; locate the line
containing the literal "cargo insta accept" in the diff and change it to "cargo
insta review" (ensure the surrounding commands "cargo test --lib --
rpc::tests::openrpc" remain unchanged).
---
Nitpick comments:
In `@docs/docs/developers/guides/release_checklist.md`:
- Line 25: Update the checklist line that reads "Make sure to update RPC specs
by running `mise insta`" to append a verification step instructing the releaser
to review the resulting snapshot diff before committing (e.g., "run `mise insta`
and review snapshot diff before commit to avoid accidental snapshot updates");
target the existing checklist item text and the `mise insta` mention so
reviewers can find and update the exact step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 6b46be59-4bc7-429f-b31c-a35e3dab8bf5
📒 Files selected for processing (2)
docs/docs/developers/guides/release_checklist.mdmise.toml
Summary of changes
Changes introduced in this pull request:
mise instatask to facilitate RPC spec updatesReference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
Documentation
Chores