Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add socket buffer size configuration #22

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

wemeetagain
Copy link
Member

Looking at performance here it appears quic has significantly reduced throughput compared with tcp. So what gives?
It may be that the OS buffer size is a factor. Whereas tcp typically has a growable OS-managed buffer, udp's buffers are fixed unless otherwise set by the application (or set via OS-wide configuration).

This PR exposes the send and receive buffer sizes (SO_SNDBUF and SO_RCVBUF) to be configurable.
Note that the OS imposes its own limits, so any values larger than the OS limits (typically for most OSs) will get clamped to the limit.

Various (semi)related links:

TODO figure out good defaults

@wemeetagain wemeetagain requested a review from achingbrain March 26, 2025 18:57
Copy link
Collaborator

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wemeetagain wemeetagain merged commit 8f9c30f into main Mar 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants