Merged
Conversation
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
This reverts commit 203cf39.
spiral-ladder
force-pushed
the
napi
branch
8 times, most recently
from
a184e7b to
8143492
Compare
Collaborator
|
I think this should be ready for a proper look. I opened #213 to fix some unrelated issues to bindings that caused some spec tests failures because of the way effective balance increments were being initialized and used. The main issue with the bindings test failing was most likely due to being OOM-killed, which we now manually sidestep by first deserializing and destructuring the treeview state before manually garbage collecting the unused state. |
wemeetagain
commented
Feb 11, 2026
Member
Author
|
I re-reviewed this and fixed up a few things. |
wemeetagain
pushed a commit
that referenced
this pull request
Feb 23, 2026
- pluralize the term - fix init issues found in #173 leading to spec tests failure
twoeths
pushed a commit
that referenced
this pull request
Mar 3, 2026
Add scaffolding for napi bindings with some example code --------- Signed-off-by: Chen Kai <281165273grape@gmail.com> Co-authored-by: Chen Kai <281165273grape@gmail.com> Co-authored-by: bing <spiralladder@fastmail.com> Co-authored-by: guha-rahul <52607971+guha-rahul@users.noreply.github.com> Co-authored-by: Jeff Chung <78428519+jeffoodchain@users.noreply.github.com> Co-authored-by: Jeff Chung <sh1001309@gmail.com>
twoeths
pushed a commit
that referenced
this pull request
Mar 3, 2026
- pluralize the term - fix init issues found in #173 leading to spec tests failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scaffolding for napi bindings with some example code