Skip to content

chore: remove stale TODO comments in slash_validator#255

Closed
lodekeeper-z wants to merge 1 commit intoChainSafe:mainfrom
lodekeeper-z:chore/remove-stale-todos-slash-validator
Closed

chore: remove stale TODO comments in slash_validator#255
lodekeeper-z wants to merge 1 commit intoChainSafe:mainfrom
lodekeeper-z:chore/remove-stale-todos-slash-validator

Conversation

@lodekeeper-z
Copy link
Copy Markdown
Contributor

Remove two TODO(ct) comments about defining electra preset constants that are already defined and in use:

  • MIN_SLASHING_PENALTY_QUOTIENT_ELECTRA — defined in preset.zig (both mainnet and minimal)
  • WHISTLEBLOWER_REWARD_QUOTIENT_ELECTRA — defined in preset.zig (both mainnet and minimal)

Both constants are already correctly referenced in the switch statements immediately below the TODOs.

🤖 Generated with AI assistance

Remove two TODO(ct) comments about defining electra preset constants
that are already defined and in use (MIN_SLASHING_PENALTY_QUOTIENT_ELECTRA,
WHISTLEBLOWER_REWARD_QUOTIENT_ELECTRA).

🤖 Generated with AI assistance
@lodekeeper-z lodekeeper-z requested a review from a team as a code owner March 21, 2026 16:06
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by eliminating two outdated TODO comments within the slash_validator function. These comments incorrectly suggested that certain Electra preset constants needed definition, when in fact, they were already properly established and in use within the codebase. The change streamlines the code by removing unnecessary annotations.

Highlights

  • Code Cleanup: Removed a stale TODO(ct) comment regarding the definition of MIN_SLASHING_PENALTY_QUOTIENT_ELECTRA, as the constant is already defined and correctly referenced.
  • Code Cleanup: Removed a stale TODO(ct) comment regarding the definition of WHISTLEBLOWER_REWARD_QUOTIENT_ELECTRA, as the constant is already defined and correctly referenced.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a simple cleanup, removing two TODO comments from src/state_transition/block/slash_validator.zig. As the pull request description notes, the constants mentioned in the TODOs (MIN_SLASHING_PENALTY_QUOTIENT_ELECTRA and WHISTLEBLOWER_REWARD_QUOTIENT_ELECTRA) are already defined and used in the code, making the comments obsolete. The change is correct and I have no further suggestions.

@lodekeeper-z
Copy link
Copy Markdown
Contributor Author

Superseded by #268, which includes this change plus additional stale TODO cleanups in process_attestation_altair.zig and process_deposit.zig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants