feat(types): add Fulu cell dissemination SSZ types#283
feat(types): add Fulu cell dissemination SSZ types#283lodekeeper-z wants to merge 2 commits intoChainSafe:mainfrom
Conversation
Add PartialDataColumnSidecar, PartialDataColumnPartsMetadata, and PartialDataColumnHeader types from consensus-specs #4558. These types support cell-level dissemination via Gossipsub partial messages, allowing individual cells to be sent instead of full data columns for more efficient data availability sampling. 🤖 Generated with AI assistance
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new SSZ container types required for Fulu cell-level dissemination. These additions enable more efficient data availability sampling by allowing peers to communicate cell availability and interest, as well as facilitating partial column dissemination via gossipsub. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new SSZ container types for Cell Dissemination in src/consensus_types/fulu.zig, specifically PartialDataColumnSidecar, PartialDataColumnPartsMetadata, and PartialDataColumnHeader. A review comment identifies a violation of the repository style guide regarding the 100-column line length limit and suggests reformatting the affected code for compliance.
| pub const PartialDataColumnHeader = ssz.VariableContainerType(struct { | ||
| kzg_commitments: ssz.FixedListType(p.KZGCommitment, preset.MAX_BLOB_COMMITMENTS_PER_BLOCK), | ||
| signed_block_header: SignedBeaconBlockHeader, | ||
| kzg_commitments_inclusion_proof: ssz.FixedVectorType(p.Bytes32, preset.KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH), |
There was a problem hiding this comment.
This line exceeds the 100-column limit specified in the repository style guide. Please reformat it for better readability.
kzg_commitments_inclusion_proof: ssz.FixedVectorType(
p.Bytes32,
preset.KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH,
)
References
- Line 400: Hard limit all line lengths, without exception, to at most 100 columns for a good typographic "measure". Use it up. Never go beyond. Nothing should be hidden by a horizontal scrollbar. Let your editor help you by setting a column ruler. To wrap a function signature, call or data structure, add a trailing comma, close your eyes and let
zig fmtdo the rest. (link)
🤖 Generated with AI assistance
1 participant
Superseded by #284 (proper branch).