[wip] feat(bindings): align BeaconStateView with IBeaconStateView

bench/state_transition/process_block.zig

@@ -68,18 +68,17 @@ fn ProcessWithdrawalsBench(comptime fork: ForkSeq) type {
                 allocator.destroy(cloned);
             }
 
+            var withdrawals_buf: [preset.MAX_WITHDRAWALS_PER_PAYLOAD]types.capella.Withdrawal.Type = undefined;
             var withdrawals_result = WithdrawalsResult{
-                .withdrawals = Withdrawals.initCapacity(allocator, preset.MAX_WITHDRAWALS_PER_PAYLOAD) catch unreachable,
+                .withdrawals = Withdrawals.initBuffer(&withdrawals_buf),
             };
-            defer withdrawals_result.withdrawals.deinit(allocator);
 
             var withdrawal_balances = std.AutoHashMap(ValidatorIndex, usize).init(allocator);
             defer withdrawal_balances.deinit();
 
             const state = cloned.state.castToFork(fork);
             state_transition.getExpectedWithdrawals(
                 fork,
-                allocator,
                 cloned.epoch_cache,
                 state,
                 &withdrawals_result,
@@ -339,15 +338,15 @@ fn ProcessBlockSegmentedBench(comptime fork: ForkSeq) type {
 
             if (comptime fork.gte(.capella)) {
                 const withdrawals_start = time.timestampNow(io);
+
+                var withdrawals_buf: [preset.MAX_WITHDRAWALS_PER_PAYLOAD]types.capella.Withdrawal.Type = undefined;
                 var withdrawals_result = WithdrawalsResult{
-                    .withdrawals = Withdrawals.initCapacity(allocator, preset.MAX_WITHDRAWALS_PER_PAYLOAD) catch unreachable,
+                    .withdrawals = Withdrawals.initBuffer(&withdrawals_buf),
                 };
-                defer withdrawals_result.withdrawals.deinit(allocator);
                 var withdrawal_balances = std.AutoHashMap(ValidatorIndex, usize).init(allocator);
                 defer withdrawal_balances.deinit();
                 state_transition.getExpectedWithdrawals(
                     fork,
-                    allocator,
                     epoch_cache,
                     state,
                     &withdrawals_result,

bindings/napi/js_types.zig

@@ -56,9 +56,9 @@ pub const Validator = js.Object(struct {
 });
 
 pub const ProposerRewards = js.Object(struct {
-    attestations: js.BigInt,
-    syncAggregate: js.BigInt,
-    slashing: js.BigInt,
+    attestations: js.Number,
+    syncAggregate: js.Number,
+    slashing: js.Number,
 });
 
 pub const MultiProof = js.Object(struct {

bindings/napi/stateTransition.zig

@@ -15,65 +15,7 @@ const allocator = if (builtin.mode == .Debug)
 else
     std.heap.c_allocator;
 
-/// Parse a JS options object into Zig's TransitionOpts.
-///
-/// Recognized fields:
-/// - verifyStateRoot, verifyProposer, verifySignatures: bool
-/// - dontTransferCache: bool (negated to set transfer_cache)
-/// - executionPayloadStatus: "valid" | "invalid" | "preMerge"
-/// - dataAvailabilityStatus: "Available" | "PreData" | "OutOfRange"
-///
-/// This is the double negative version to conform with production lodestar.
-/// TODO(bing): Eventually rename this to `transferCache` to avoid double negation because its confusing naming.
-fn parseOptions(options: ?js.Value) !st.TransitionOpts {
-    var transition_opts: st.TransitionOpts = .{};
-    if (options) |value| {
-        const raw = value.toValue();
-        if (try raw.typeof() == .object) {
-            if (try raw.hasNamedProperty("verifyStateRoot")) {
-                transition_opts.verify_state_root = try (try raw.getNamedProperty("verifyStateRoot")).getValueBool();
-            }
-            if (try raw.hasNamedProperty("verifyProposer")) {
-                transition_opts.verify_proposer = try (try raw.getNamedProperty("verifyProposer")).getValueBool();
-            }
-            if (try raw.hasNamedProperty("verifySignatures")) {
-                transition_opts.verify_signatures = try (try raw.getNamedProperty("verifySignatures")).getValueBool();
-            }
-            if (try raw.hasNamedProperty("dontTransferCache")) {
-                transition_opts.transfer_cache = !(try (try raw.getNamedProperty("dontTransferCache")).getValueBool());
-            }
-            if (try raw.hasNamedProperty("executionPayloadStatus")) {
-                var buf: [16]u8 = undefined;
-                const execution_payload_status = try (try raw.getNamedProperty("executionPayloadStatus")).getValueStringUtf8(&buf);
-                transition_opts.block_external_data.execution_payload_status =
-                    if (std.mem.eql(u8, execution_payload_status, "valid"))
-                        .valid
-                    else if (std.mem.eql(u8, execution_payload_status, "invalid"))
-                        .invalid
-                    else if (std.mem.eql(u8, execution_payload_status, "preMerge"))
-                        .pre_merge
-                    else
-                        return error.InvalidExecutionPayloadStatus;
-            }
-            if (try raw.hasNamedProperty("dataAvailabilityStatus")) {
-                var buf: [16]u8 = undefined;
-                const da_status = try (try raw.getNamedProperty("dataAvailabilityStatus")).getValueStringUtf8(&buf);
-                transition_opts.block_external_data.data_availability_status =
-                    if (std.mem.eql(u8, da_status, "Available"))
-                        .available
-                    else if (std.mem.eql(u8, da_status, "PreData"))
-                        .pre_data
-                    else if (std.mem.eql(u8, da_status, "OutOfRange"))
-                        .out_of_range
-                        // TODO(bing): uncomment once gloas support is in
-                        // else if (std.mem.eql(u8, da_status, "NotRequired")) .not_required;
-                    else
-                        return error.InvalidDataAvailabilityStatus;
-            }
-        }
-    }
-    return transition_opts;
-}
+const parseOptions = @import("./transition_opts.zig").parseOptions;
 
 /// Perform a state transition given a signed beacon block.
 ///

bindings/napi/transition_opts.zig

@@ -0,0 +1,73 @@
+//! Shared parser for `TransitionOpts` from a JS options object.
+//!
+//! This file is intentionally not registered with `root.zig` as a module export —
+//! its `pub fn` should be visible to other napi files but never auto-exposed to JS.
+//! (zapi tries to export every pub fn in modules listed in `root.zig`, which would
+//! fail here because `TransitionOpts` isn't a JS-convertible return type.)
+
+const std = @import("std");
+const js = @import("zapi:zapi").js;
+const st = @import("state_transition");
+
+/// Parse a JS options object into Zig's `TransitionOpts`.
+///
+/// Recognized fields:
+/// - `verifyStateRoot`, `verifyProposer`, `verifySignatures`: bool
+/// - `dontTransferCache`: bool (negated to set `transfer_cache`)
+/// - `executionPayloadStatus`: "valid" | "invalid" | "preMerge"
+/// - `dataAvailabilityStatus`: "Available" | "PreData" | "OutOfRange"
+///
+/// Throws `error.InvalidExecutionPayloadStatus` / `error.InvalidDataAvailabilityStatus`
+/// for unknown enum strings.
+///
+/// TODO(bing): rename `dontTransferCache` → `transferCache` to drop the double negation.
+pub fn parseOptions(options: ?js.Value) !st.TransitionOpts {
+    var transition_opts: st.TransitionOpts = .{};
+
+    if (options) |value| {
+        const raw = value.toValue();
+        if (try raw.typeof() == .object) {
+            if (try raw.hasNamedProperty("verifyStateRoot")) {
+                transition_opts.verify_state_root = try (try raw.getNamedProperty("verifyStateRoot")).getValueBool();
+            }
+            if (try raw.hasNamedProperty("verifyProposer")) {
+                transition_opts.verify_proposer = try (try raw.getNamedProperty("verifyProposer")).getValueBool();
+            }
+            if (try raw.hasNamedProperty("verifySignatures")) {
+                transition_opts.verify_signatures = try (try raw.getNamedProperty("verifySignatures")).getValueBool();
+            }
+            if (try raw.hasNamedProperty("dontTransferCache")) {
+                transition_opts.transfer_cache = !(try (try raw.getNamedProperty("dontTransferCache")).getValueBool());
+            }
+            if (try raw.hasNamedProperty("executionPayloadStatus")) {
+                var buf: [16]u8 = undefined;
+                const status_str = try (try raw.getNamedProperty("executionPayloadStatus")).getValueStringUtf8(&buf);
+                transition_opts.block_external_data.execution_payload_status =
+                    if (std.mem.eql(u8, status_str, "valid"))
+                        .valid
+                    else if (std.mem.eql(u8, status_str, "invalid"))
+                        .invalid
+                    else if (std.mem.eql(u8, status_str, "preMerge"))
+                        .pre_merge
+                    else
+                        return error.InvalidExecutionPayloadStatus;
+            }
+            if (try raw.hasNamedProperty("dataAvailabilityStatus")) {
+                var buf: [16]u8 = undefined;
+                const da_str = try (try raw.getNamedProperty("dataAvailabilityStatus")).getValueStringUtf8(&buf);
+                transition_opts.block_external_data.data_availability_status =
+                    if (std.mem.eql(u8, da_str, "Available"))
+                        .available
+                    else if (std.mem.eql(u8, da_str, "PreData"))
+                        .pre_data
+                    else if (std.mem.eql(u8, da_str, "OutOfRange"))
+                        .out_of_range
+                        // TODO(bing): uncomment once gloas support is in
+                        // else if (std.mem.eql(u8, da_str, "NotRequired")) .not_required;
+                    else
+                        return error.InvalidDataAvailabilityStatus;
+            }
+        }
+    }
+    return transition_opts;
+}