Merged
Conversation
twoeths
commented
May 2, 2025
| mv release_tmp/libstate-transition-utils-x86_64-linux.so/libstate-transition-utils.so release/libstate-transition-utils-x86_64-linux.so | ||
| mv release_tmp/libstate-transition-utils-aarch64-linux.so/libstate-transition-utils.so release/libstate-transition-utils-aarch64-linux.so | ||
| mv release_tmp/libstate-transition-utils-x86_64-macos.dylib/libstate-transition-utils.dylib release/libstate-transition-utils-x86_64-macos.dylib | ||
| mv release_tmp/libstate-transition-utils-pk_aarch64-macos.dylib/libstate-transition-utils.dylib release/libstate-transition-utils-aarch64-macos.dylib |
Collaborator
Author
There was a problem hiding this comment.
removing "pk_" is the main fix
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
pushed a commit
that referenced
this pull request
Nov 12, 2025
lodekeeper-z
added a commit
to lodekeeper-z/lodestar-z
that referenced
this pull request
Mar 28, 2026
Per the Engine API spec, blockNumber, gasLimit, gasUsed, timestamp, baseFeePerGas, blob_gas_used, excess_blob_gas, and withdrawal fields (index, validatorIndex, amount) must be QUANTITY (variable-length hex, no leading zeros), not fixed-width DATA encoding. Replace hexEncodeU64/hexEncodeU256 with hexEncodeQuantity/hexEncodeQuantityU256 in all encode functions: encodeExecutionPayloadV1/V2/V3/V4, encodeWithdrawal, encodeDepositRequest, encodeWithdrawalRequest, and encodePayloadAttributesV1/V2/V3. Fixes critical issue #1 and medium issue ChainSafe#5 from REVIEW.md. 🤖 Generated with AI assistance
lodekeeper-z
added a commit
to lodekeeper-z/lodestar-z
that referenced
this pull request
Mar 28, 2026
- attestation_service: use signing_ctx.slots_per_epoch instead of hardcoded /32 in reorg handler (fix #1) - sync_committee_service: add TODO comments noting SYNC_COMMITTEE_SIZE=512 and SUBNET_COUNT=4 are mainnet-only; minimal preset differs (fix ChainSafe#2) - validator: add TODO comment on hardcoded 256 EPOCHS_PER_SYNC_COMMITTEE_PERIOD (fix ChainSafe#3) - attestation_service: rename getDutiesAtSlot(slot) -> allDuties() since the slot param was unused; update call site (fix ChainSafe#4) - signing: add current_epoch param to voluntaryExitSigningRoot() instead of calling std.time.timestamp() internally; keeps function pure/testable (fix ChainSafe#5) - validator: replace inline @import("doppelganger.zig") with dopple_mod alias already imported at top of file (fix ChainSafe#6) - validator_store: change isRemote from *const to *ValidatorStore since it calls mutex.lock() which requires mutability (fix ChainSafe#7) 🤖 Generated with AI assistance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.