Conversation
twoeths
commented
May 9, 2025
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
commented
May 12, 2025
wemeetagain
reviewed
May 12, 2025
This reverts commit e864fb6.
wemeetagain
reviewed
May 15, 2025
| }; | ||
|
|
||
| // Load the compiled Zig shared library | ||
| const lib = await openLibrary(path.resolve("../bun"), fns); |
Member
There was a problem hiding this comment.
the path.resolve("../bun") is strange here. I don't think it will work when the cwd is another consumer of this package.
maybe better is path.join(import.meta.dirname, '..')
(I'm assuming the dylib would be located at something like bun/libstate-transition-utils.dylib)
Collaborator
Author
There was a problem hiding this comment.
I simplified it to const lib = await openLibrary(path.resolve("."), fns); please have a look at the latest change
Member
There was a problem hiding this comment.
@twoeths check this comment. Try something with import.meta.dirname here instead of path.resolve/cwd
Collaborator
Author
There was a problem hiding this comment.
thanks, just switched to "import.meta.dirname"
twoeths
force-pushed
the
te/consume_bun-ffi-z
branch
from
3c6482f to
6c060fc
Compare
twoeths
force-pushed
the
te/consume_bun-ffi-z
branch
from
2bc92dd to
f28257c
Compare
twoeths
force-pushed
the
te/consume_bun-ffi-z
branch
from
714a29b to
d848013
Compare
Collaborator
Author
|
the |
wemeetagain
pushed a commit
that referenced
this pull request
Nov 12, 2025
wemeetagain
pushed a commit
that referenced
this pull request
Mar 12, 2026
lodekeeper-z
added a commit
to lodekeeper-z/lodestar-z
that referenced
this pull request
Mar 28, 2026
…, outbound API ## Gossip → Beacon Node pipeline (issue ChainSafe#9) - Add on_validated_message callback to EthGossipAdapter (setMessageHandler(ctx, callback) — called for every ACCEPT-validated message) - validateDecoded() now delivers accepted messages to the BN processing pipeline - Beacon node wires this to enqueue blocks/attestations for import ## Gossipsub ACCEPT/REJECT feedback (issue ChainSafe#11) - handleMessage() now accepts from_peer: ?[]const u8 parameter - For REJECT outcomes, calls gossipsub.router.recordInvalidMessage(peer, topic) which increments the P4 (invalid message delivery) score counter - pollEvents() passes msg.from to handleMessage() - Gossipsub can now penalize peers who send invalid messages ## Outbound request API (issue ChainSafe#10) - Add decodeResponseChunks() + freeDecodedResponseChunks() to req_resp_encoding.zig to parse a complete response wire buffer into []DecodedResponseChunk - handleOutbound() now decodes the response and calls ctx.on_response callback if present, passing parsed chunks to the caller (sync service, etc.) - Export new types from root.zig (DecodedResponseChunk, decodeResponseChunks, freeDecodedResponseChunks) 🤖 Generated with AI assistance
lodekeeper-z
added a commit
to lodekeeper-z/lodestar-z
that referenced
this pull request
Mar 28, 2026
Medium issue ChainSafe#9 from REVIEW.md: two overlapping unknown-block mechanisms existed without clear documentation of which to use when. Add detailed module-level doc to unknown_block.zig explaining: - UnknownBlockSync: triggered by gossip blocks with unknown parent; stores full block bytes; resolves by parent chain walk + recursive import - UnknownChainSync: triggered by unknown roots from attestations/status; no block bytes, only roots; resolves by backwards header chain to fork choice, then triggers forward range sync - The key distinction: UnknownBlockSync has the block, UnknownChainSync does not. They are complementary, not redundant. 🤖 Generated with AI assistance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
TODOs
bun run buildbun test:unitbun benchmarkbun prePublish. ==> tested in feat: prepublish step in workflow #11bun publish