chore: release 1.34.1 patch #8366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation** Users reported in the v1.34.0 release that changes in the release created an issue when ipv6 and ipv4 ports were the same: ``` ✖ Error: Timeout: Did not receive an init message from worker after 300000ms. Make sure the worker calls expose(). ``` **Description** This PR bumps discv5 from 11.0.3 to 11.0.4 which includes the fix to binding ipv4 and ipv6 on the same port in dual stack mode. See: ChainSafe/discv5#318
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @philknows, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers a patch release, version 1.34.1, primarily to deploy a critical hotfix. The fix resolves a networking problem where users operating in dual-stack mode were unable to utilize the same port for both IPv4 and IPv6 connections. This was achieved by updating a key underlying dependency.
Highlights
- Version Bump: The project version has been incremented to
1.34.1across all packages, signifying a patch release. - Critical Hotfix: This release includes a hotfix addressing an issue where users in dual-stack mode were unable to use the same port for both IPv4 and IPv6 connections.
- Dependency Update: The
@chainsafe/discv5dependency has been updated to version11.0.4to resolve the dual-stack port issue.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
nflaig
approved these changes
Sep 10, 2025
Contributor
There was a problem hiding this comment.
Code Review
This pull request prepares the 1.34.1 patch release. The changes consist of version bumps across all packages in the monorepo from 1.34.0 to 1.34.1. Notably, it includes an update to the @chainsafe/discv5 dependency to version ^11.0.4, which is the core hotfix this release addresses. All changes appear correct and consistent for a patch release.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable #8366 +/- ##
==========================================
- Coverage 54.08% 54.07% -0.01%
==========================================
Files 849 849
Lines 64121 64121
Branches 4854 4853 -1
==========================================
- Hits 34678 34674 -4
- Misses 29366 29370 +4
Partials 77 77 🚀 New features to boost your workflow:
|
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Member
Author
|
Confirm fixed. 
|
Member
|
🎉 This PR is included in v1.34.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This hotfix addresses users who are using the same port for both ipv4 and ipv6 in dual stack mode.
Description
Fix #8365 is included to bump discv5, to prevent users from having to use different ports for ipv4 and ipv6.