-
-
Notifications
You must be signed in to change notification settings - Fork 435
chore: use native arm64 runners instead of qemu for docker builds #8821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Performance Report✔️ no performance regression detected Full benchmark results
|
| - arch: amd64 | ||
| runner: buildjet-4vcpu-ubuntu-2204 | ||
| - arch: arm64 | ||
| runner: buildjet-4vcpu-ubuntu-2204-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this runner works well we should consider using it instead of lodestar-arm64-runner for our binary builds
@philknows do you know who maintains the custom runner right now?
lodekeeper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥
Nice refactor of the Docker build pipeline:
Improvements:
- Native ARM64 runners (BuildJet) instead of QEMU emulation = much faster builds
- Reusable workflow (
docker.yml) reduces duplication across publish-*.yml files - Better sanity check — actually runs the container and curls the API endpoint instead of just
--help - Arch-specific images with multi-arch manifest = cleaner tagging
The test run shows it's working: https://github.com/ChainSafe/lodestar/actions/runs/21526694126
Good improvement for CI performance!
Motivation
Speed up docker builds
Description
buildjet-4vcpu-ubuntu-2204-armfor armSee https://buildjet.com/for-github-actions/docs/guides/migrating-to-arm
Test run https://github.com/ChainSafe/lodestar/actions/runs/21526694126