Skip to content

test: correct lightclient committee root test for electra #8825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lodekeeper wants to merge 2 commits into
base: unstable
Choose a base branch
from
+12 −21
Open

test: correct lightclient committee root test for electra #8825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99941e8
test: correct lightclient committee root test for electra
lodekeeper Jan 31, 2026
17894d5
fix: type errors in lightclient endpoint test
lodekeeper Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 12 additions & 21 deletions packages/beacon-node/test/e2e/api/impl/lightclient/endpoint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import {afterEach, beforeEach, describe, expect, it} from "vitest";
import {aggregateSerializedPublicKeys} from "@chainsafe/blst";
import {HttpHeader, getClient, routes} from "@lodestar/api";
import {ChainConfig, createBeaconConfig} from "@lodestar/config";
import {ForkName, SYNC_COMMITTEE_SIZE} from "@lodestar/params";
import {phase0, ssz} from "@lodestar/types";
import {ForkName} from "@lodestar/params";
import {CachedBeaconStateAltair} from "@lodestar/state-transition";
import {phase0} from "@lodestar/types";
import {sleep} from "@lodestar/utils";
import {Validator} from "@lodestar/validator";
import {BeaconNode} from "../../../../../src/node/nodejs.js";
Expand Down Expand Up @@ -119,29 +119,20 @@ describe("lightclient api", () => {
expect(finalityUpdate).toBeDefined();
});

it.skip("getLightClientCommitteeRoot() for the 1st period", async () => {
// need to investigate why this test fails after upgrading to electra
// TODO: https://github.com/ChainSafe/lodestar/issues/8723
it("getLightClientCommitteeRoot() for the 1st period", async () => {
await waitForBestUpdate();

const lightclient = getClient({baseUrl: `http://127.0.0.1:${restPort}`}, {config}).lightclient;
const committeeRes = await lightclient.getLightClientCommitteeRoot({startPeriod: 0, count: 1});
committeeRes.assertOk();
const client = getClient({baseUrl: `http://127.0.0.1:${restPort}`}, {config}).beacon;
const validators = (await client.postStateValidators({stateId: "head"})).value();
const pubkeys = validators.map((v) => v.validator.pubkey);
expect(pubkeys.length).toBe(validatorCount);
// only 2 validators spreading to 512 committee slots
const committeePubkeys = Array.from({length: SYNC_COMMITTEE_SIZE}, (_, i) =>
i % 2 === 0 ? pubkeys[0] : pubkeys[1]
);
const aggregatePubkey = aggregateSerializedPublicKeys(committeePubkeys).toBytes();

// Get the actual sync committee root from the head state
// The sync committee is computed using a weighted random shuffle, not simple alternation
// Since the test starts at Electra, headState is always post-Altair and has currentSyncCommittee
const headState = bn.chain.getHeadState() as CachedBeaconStateAltair;
const expectedRoot = headState.currentSyncCommittee.hashTreeRoot();

// single committee hash since we requested for the first period
expect(committeeRes.value()).toEqual([
ssz.altair.SyncCommittee.hashTreeRoot({
pubkeys: committeePubkeys,
aggregatePubkey,
}),
]);
expect(committeeRes.value()).toEqual([expectedRoot]);
});
});
Loading