Skip to content

fix: make column reconstruction delay a function of slot time #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lodekeeper wants to merge 5 commits into
base: unstable
Choose a base branch
from
+8 −4
Open

fix: make column reconstruction delay a function of slot time #8827

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93a68b8
fix: make column reconstruction delay a function of slot time
lodekeeper Jan 31, 2026
851298f
refactor: use basis points for reconstruction delay constants
lodekeeper Jan 31, 2026
48e6b61
refactor: use getSlotComponentDurationMs helper for BPS conversion
lodekeeper Jan 31, 2026
9eb6297
docs: simplify JSDoc comments for reconstruction delay constants
lodekeeper Jan 31, 2026
10b1fd1
refactor: pre-calculate delay values in constructor
lodekeeper Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/beacon-node/src/chain/ColumnReconstructionTracker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ import {ChainEventEmitter} from "./emitter.js";
/**
* Minimum time to wait before attempting reconstruction
*/
const RECONSTRUCTION_DELAY_MIN_MS = 800;
const RECONSTRUCTION_DELAY_MIN_BPS = 667;

/**
* Maximum time to wait before attempting reconstruction
*/
const RECONSTRUCTION_DELAY_MAX_MS = 1200;
const RECONSTRUCTION_DELAY_MAX_BPS = 1000;

export type ColumnReconstructionTrackerInit = {
logger: Logger;
Expand Down Expand Up @@ -41,11 +41,16 @@ export class ColumnReconstructionTracker {
/** Track if a reconstruction attempt is in-flight */
running = false;

private readonly minDelayMs: number;
private readonly maxDelayMs: number;

constructor(init: ColumnReconstructionTrackerInit) {
this.logger = init.logger;
this.emitter = init.emitter;
this.metrics = init.metrics;
this.config = init.config;
this.minDelayMs = this.config.getSlotComponentDurationMs(RECONSTRUCTION_DELAY_MIN_BPS);
this.maxDelayMs = this.config.getSlotComponentDurationMs(RECONSTRUCTION_DELAY_MAX_BPS);
}

triggerColumnReconstruction(blockInput: BlockInputColumns): void {
Expand All @@ -61,8 +66,7 @@ export class ColumnReconstructionTracker {
// just that it has been triggered for this block root.
this.running = true;
this.lastBlockRootHex = blockInput.blockRootHex;
const delay =
RECONSTRUCTION_DELAY_MIN_MS + Math.random() * (RECONSTRUCTION_DELAY_MAX_MS - RECONSTRUCTION_DELAY_MIN_MS);
const delay = this.minDelayMs + Math.random() * (this.maxDelayMs - this.minDelayMs);
sleep(delay)
.then(() => {
const logCtx = {slot: blockInput.slot, root: blockInput.blockRootHex};
Expand Down
Loading