fix(heze): raise MAX_SIGNED_INCLUSION_LIST_SIZE to the derived bound and reject empty transactions - #9936
Open
barnabasbusa wants to merge 1 commit into
Conversation
2 tasks
…and reject empty transactions consensus-specs#5576: MAX_SIGNED_INCLUSION_LIST_SIZE (8348) only fit a single-transaction list, since each transaction adds a 4-byte SSZ offset on top of MAX_TRANSACTIONS_BYTES_PER_INCLUSION_LIST. A full list of ~65 transactions serializes to ~8600 bytes and could not be published. The bound becomes 152 + 5 * MAX_TRANSACTIONS_BYTES_PER_INCLUSION_LIST = 41112, the size of a list of one-byte transactions, and gossip validation rejects empty transactions so that bound is finite. Claude-Session: https://claude.ai/code/session_01YHCg1Q6QaZn8rPjB7za3UB
barnabasbusa
changed the title
barnabasbusa
force-pushed
the
fix/heze-il-serialized-size
branch
from
August 28, 2026 13:34
7de9e8b to
e14d098
Compare
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to #9935 for ethereum/consensus-specs#5576 (issue ethereum/consensus-specs#5575).
MAX_SIGNED_INCLUSION_LIST_SIZE = 8348only fits a single-transaction list: every transaction adds a 4-byte SSZ offset on top ofMAX_TRANSACTIONS_BYTES_PER_INCLUSION_LIST, so a full list of ~65 transactions serializes to ~8600 bytes andoutboundTransformrefuses to publish it (ssz_snappy encoded data length 8586 > 8348— 209 of 211 publishes onfocil-devnet-0).Description
Tracks the direction taken in consensus-specs#5576 (keep the raw-bytes rule, derive the message bound from it):
MAX_SIGNED_INCLUSION_LIST_SIZE: 8348 → 41112 in both presets (152 + 5 · MAX_TRANSACTIONS_BYTES_PER_INCLUSION_LIST, the size of a list of one-byte transactions — the largest spec-valid list, with no assumption about EL transaction encoding).[REJECT]an inclusion list containing an empty transaction (INCLUSION_LIST_ERROR_EMPTY_TRANSACTION), which is what makes that bound finite.The constant is used as the
inclusion_listtopic's max message size (getGossipSSZMaxSize); nothing else changes. If the spec settles on a tighter derived value instead (see the PR), only the constant moves.Testing
pnpm build,check-typesonparams/beacon-node, biome clean;topic.test.ts/inclusionListStore.test.tspass.https://claude.ai/code/session_01YHCg1Q6QaZn8rPjB7za3UB