Do not import games other than chess (no bughouse & c) which results …#1
Open
maurino wants to merge 1 commit intoChameleonRed:masterfrom
Open
Do not import games other than chess (no bughouse & c) which results …#1maurino wants to merge 1 commit intoChameleonRed:masterfrom
maurino wants to merge 1 commit intoChameleonRed:masterfrom
Conversation
Owner
|
Change is O.K. but problem is that I want designed import only chess games. Maybe adding other games types can be option, if you send some small mixed pgn I can study this but I am busy so it can take months. |
Owner
|
It looks that you skip other games types. I need to check it since I am not familiar with github "merging" I use more often git :) |
Owner
|
I forgot how program works pgn is not need but account is need to download games (with bughouse). Better can be check if 'pgn' is present so I will do probably this check (more flexible). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
my name is Mauro. Thank you for your project, I fixed a little bug, when it generates an exception trying to import a bughouse games mixed into my regular games (bughouse uses FEN instead of PGN)
Shoud it work, now
Best regards
Mauro