Skip to content

Add "approve", and "disapprove" #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syvb wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add "approve", and "disapprove" #6

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c33e322
Add "approve", and "disapprove"
syvb Nov 4, 2017
2bd0070
Merge branch 'master' into Smittyvb-patch-3
syvb Nov 30, 2017
4577f4d
Put "disapprove" back
syvb Nov 30, 2017
6d782ae
fix
syvb Dec 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ if (PROD) {
}
const THRESHOLD = 4;
const { exec } = require('child_process');
const UPVOTES = ["+1", "upvote", "i like it", "i really like it", "👍"];
const DOWNVOTES = ["-1", "downvote", "i dislike it", "i really dislike it", "i hate it", "i really hate it", "👎"];
const UPVOTES = ["+1", "upvote", "i like it", "i really like it", "👍", "disapprove"];
const DOWNVOTES = ["-1", "downvote", "i dislike it", "i really dislike it", "i hate it", "i really hate it", "👎", "approve"];var GitHub = require('github-api');
Copy link
Copy Markdown

@mdcfe mdcfe Dec 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't disapprove be a downvote, and approve be an upvote?

Copy link
Copy Markdown
Contributor

@Kroppeb Kroppeb Dec 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha Ha


var GitHub = require('github-api');

// basic auth
Expand Down