Using enum's to represent currency #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

abrishk26 wants to merge 2 commits into Chapa-Et:main from abrishk26:main

abrishk26 commented Oct 27, 2025

Pull Request

Short description

What: Changed the currency fields on different structs to Currency enum.
Why: Using enums makes it clear instead of strings in this case.
How: Changed the fields to use Currency enum from the bank module.

Checklist

[ ☑] PR targets the correct branch
[☑ ] Code compiles without errors
Tests added/updated or not applicable
CI passes
Docs/CHANGELOG updated if needed
[ ☑] PR follows Conventional Commits (feat:, fix:, docs:, etc.)

Related

Testing

Run: make check
Notes: add any manual steps if required

abrishk26 added 2 commits

October 27, 2025 19:09


          fix: change the structs currency field to use the exsting enum

106f06a


          fix: remove unused imports

86e3af3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet