Add a Docker one-liner run example to the README #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had trouble running the provided Docker image on my Mac and my Raspberry Pi because it was only published in amd64 architecture. While we should probably publish the image in all architectures, this is a quick documentation fix to provide a one-liner for folks to run with Docker on any architecture using Caddy.
✅ Deploy Preview for keen-bublanina-30b4ef ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Owner
|
@alkoclick heyyy, it's that time of the year again and I'm back to working on this project ^^ Edit: Ah, nevermind, you're telling caddy to serve on 2024 at the end, and vite isn't used at all since we're dealing with the built files. |
Owner
|
In that case, I think we can make it a bit clearer that the user needs to first download the zip archive, then extract it somewhere, and then link that up to the docker image via the path binding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble running the provided Docker image on my Mac and my Raspberry Pi because it was only published in amd64 architecture. While we should probably publish the image in all architectures, this is a quick documentation fix to provide a one-liner for folks to run with Docker on any architecture using Caddy.