Add failing test example + error lines helper #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (err) { | ||
| const {start, end} = err.location, | ||
| lines = rppString.split(/\r?\n/ig).map(l => ' ' + l) | ||
| err.nearLines = lines.slice(start.line - 4, start.line - 1) |
Owner
There was a problem hiding this comment.
Thanks for the PR, @JohnnyMarnell ! I'm publishing v0.4.2 to npm, which includes JSFX support.
I'm thinking about adding this too, but can you confirm that this works as expected when the calculated indices are outside the bounds of the array? For example when the error occurs on the very first or last line in the input string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What a great repo, thank you! I tried it on a current
.RPPI'm working on, I'm getting a few errors, but the gnarliest seems to be when a line (in my case, part of a jsfx<JSblock) begins with a decimal param value.I added 2 tests, one passes (first param is integer) and the other fails. (Wish I had a fix, but peg is new to me and I'm not yet grokking it).
I also included augmenting the error object with helpful context (highlighting failing line with approx +-5 lines surrounding), in case that's something other folks would also find helpful.
Hope to collab! @CharlesHolbrow