feat: Add tests for submitting measurements #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
* Add tests for listing arweave nodes * Remove redundant test * format * Update tests/nodes.test.js Co-authored-by: Miroslav Bajtoš <[email protected]> --------- Co-authored-by: Miroslav Bajtoš <[email protected]>
…work/arweave-checker into feat/submit-measurement
This was referenced Mar 7, 2025
|
Converting to draft until #15 gets merged |
|
I have unassigned myself from the review. Please re-assign me after this PR is ready for review & merging. |
Co-authored-by: Miroslav Bajtoš <[email protected]>
…weave-checker into feat/list-recent-transactions
…work/arweave-checker into feat/list-recent-transactions
…work/arweave-checker into feat/submit-measurement
| * @param {typeof globalThis.fetch} fetch | ||
| */ | ||
| export const submit = async (measurement, fetch = globalThis.fetch) => { | ||
| const res = await fetch('https://api.checker.network/arweave/measurement', { |
There was a problem hiding this comment.
should we perform a retry here?
There was a problem hiding this comment.
I'm not exactly sure as we're not retrying with spark-checker too.
Co-authored-by: Nikolas Haimerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract measurement function to separate lib module and adds tests.
Closes #12