Add integrate recent participants contract #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested changes
Sep 13, 2024
There was a problem hiding this comment.
IIRC, we were discussing a different approach in the past:
- spark-evaluate creates a JSON object linking to measurement commitments included in the evaluation plus the evaluation outcomes
- spark-evaluate uploads this JSON object to web3storage and commits the CID of this JSON object to the smart contract
- the smart contract emits an event with the round index and evaluation commitment CID
- spark-stats listens for these events, downloads the evaluation results & linked measurements, and runs data analysis & aggregation over the data obtained this way
I'd rather avoid creating many smart contract methods & events individually for each stats field like "recent participants" because it would be a lot of work, IMO.
In particular, if we are interested in recent participants only, then I don't think we need a new contract for that - we can find the participant addresses either in the committed measurements or in the history of setScores calls.
Comment on lines
+18
to
+30
| export const createMeridianContract = (contractAddress = SparkImpactEvaluator.ADDRESS) => { | ||
| return new ethers.Contract( | ||
| contractAddress, | ||
| SparkImpactEvaluator.ABI, | ||
| provider | ||
| ) | ||
| } | ||
|
|
||
| export const recentParticipantsContract = new ethers.Contract( | ||
| SparkEvaluationsRecentParticipants.ADDRESS, | ||
| SparkEvaluationsRecentParticipants.ABI, | ||
| provider | ||
| ) |
There was a problem hiding this comment.
Do you know why we need a factory function for the meridian contract (createMeridianContract)? I find it surprising that there isn't a factory function for "recent participants" contract as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/filecoin-station/spark-evaluations-recent-participants
Also added a refactor of
ie-contract.js, while I was there.