Skip to content

Unit Coverage Boost + Group By Filter State, .sh Hover Popup and SCA Triage Fixes (AST-137809)#428

Merged
cx-anand-nandeshwar merged 17 commits into
mainfrom
other/integration
Mar 30, 2026
Merged

Unit Coverage Boost + Group By Filter State, .sh Hover Popup and SCA Triage Fixes (AST-137809)#428
cx-anand-nandeshwar merged 17 commits into
mainfrom
other/integration

Conversation

@cx-atish-jadhav

@cx-atish-jadhav cx-atish-jadhav commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

  • Increase unit test coverage: plugin-checkmarx-ast to ~47%, common-lib to ~56%.
  • Fix AST-136209: clear JetBrains plugin login session on uninstall via PluginLifecycleHandler.java.
  • Fix AST-125205: ensure hover popup shows for secret vulnerabilities in .sh files via ProblemBuilder.java.
  • Fix AST-141818: Filter State Not Persisting After IDE Restart
  • Fix AST-140523: Ignore button not working as expected
  • fIX AST-139895: Pin checkmarx/ast-github-action to full commit SHA (327efb5d1dd16ac6c7c21a9ff8ec1e8ec393b5e6) in checkmarx-one-scan.yml.
  • fix AST-143262: JetBrains | Group By Filter not persist after IDE restart and it does in VsCode

References

  • AST-136209 (Jetbrains | Login session data is getting retained in the jetbrains plugin)
  • AST-125205 (QA | Secret vulnerabilities detected in .sh file, hover popup not displayed)
  • AST-137809 (Increase Unit Test case Coverage to for IntelliJ from 26 to 85%)
  • AST-141818 (JetBrains | Filter State Not Persisting After IDE Restart)
  • AST-140523 (Salesforce |00270503|IntelliJ IDEA| Ignore button not working as expected)
  • AST-139895 Branch commit: 2db5b35 (coverage bumps and fixes)
  • AST-143262 (JetBrains | Group By Filter not persist after IDE restart and it does in VsCode)

Testing

Unit tests: (run the relevant modules)

  • ./gradlew :plugin-checkmarx-ast:test
  • ./gradlew :common-lib:test
  • Jacoco reports reviewed for coverage improvements.
  • Manual: verify uninstall clears session state and hover popup appears for .sh secret findings.
  • Note: Update with actual commands/results you executed.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

cx-anand-nandeshwar and others added 14 commits March 10, 2026 13:54
@cx-anand-nandeshwar
Common-lib module test cases (AST 138339) (#420)
3a731e2 
* - Added new unit test cases for common-lib module
@cx-atish-jadhav
increasing unit test coverage from 26 % to 33%
b8f7dff
@cx-atish-jadhav
adding unit tests and fix for bug AST-136209
2db5b35
@cx-atish-jadhav
Ensure logout message and state on plugin uninstall by clearing auth …
190f570 
…session and tokens
@cx-atish-jadhav
fix for bug AST-136208
256e97c
@cx-atish-jadhav
Merge branch 'main' into other/unit_test_coverage
07c825f
@cx-atish-jadhav
Squashed commit of the following:
f91eac4 
commit 86f8f86
Author: Aniket Shinde <aniket.shinde@checkmarx.com>
Date:   Tue Mar 17 10:23:32 2026 +0530

    Devassist asca behaviour
@cx-atish-jadhav
Updating wrapper version from 2.4.21 to 2.4.21.1-dev
cbbc2cc
@cx-aniket-shinde
Resolved unit test cases failing
2c7e333
@cx-atish-jadhav
Updated jacksonBomVersion=2.21.1 in gradle.properties
61407d2
@cx-atish-jadhav
align Jackson versions via enforced BOM and exclude wrapper Jackson t…
23f8755 
…ransitive deps
@cx-atish-jadhav
testcase fix
0723884
@cx-aniket-shinde
Group By Filter changes
83d2e1c
@cx-atish-jadhav
merging branch bug/filter_state_AST-141818
d71e237
@github-actions

github-actions Bot commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Details – 8650edb3-0454-4ac8-b28a-27a13e4661fb

Great job! No new security vulnerabilities introduced in this pull request

cx-anand-nandeshwar
cx-anand-nandeshwar suggested changes Mar 24, 2026
View reviewed changes
Comment thread devassist-lib/src/main/java/com/checkmarx/intellij/devassist/ignore/IgnoreManager.java Outdated
Comment thread devassist-lib/src/main/java/com/checkmarx/intellij/devassist/ignore/IgnoreManager.java Outdated
Comment thread ...-lib/src/main/java/com/checkmarx/intellij/devassist/scanners/asca/AscaScanResultAdaptor.java Outdated
@cx-atish-jadhav cx-atish-jadhav changed the title Unit Coverage Boost + Filter State, Hover Popup and SCA Triage Fixes (AST-137809) Unit Coverage Boost + Group By Filter State, .sh Hover Popup and SCA Triage Fixes (AST-137809) Mar 25, 2026
@cx-anand-nandeshwar cx-anand-nandeshwar enabled auto-merge (squash) March 30, 2026 10:21
@cx-anand-nandeshwar cx-anand-nandeshwar self-requested a review March 30, 2026 10:22
@cx-anand-nandeshwar cx-anand-nandeshwar merged commit 8203da1 into main Mar 30, 2026
7 of 8 checks passed
@cx-anand-nandeshwar cx-anand-nandeshwar deleted the other/integration branch March 30, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-aniket-shinde cx-aniket-shinde Awaiting requested review from cx-aniket-shinde

1 more reviewer

@cx-anand-nandeshwar cx-anand-nandeshwar cx-anand-nandeshwar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cx-atish-jadhav @cx-anand-nandeshwar @cx-aniket-shinde