Skip to content

Commit 517ac50

Browse files
19851 cisco_meraki: fix wrong host label name
Meraki should not be included in the path for the host label name. This is how it was in the external MKP. But due to changes in the network topology, this needs to be dropped. CMK-33930 Change-Id: I667a063f1579ca23bdaa66c755d036824050d6b6
1 parent 1834e6d commit 517ac50

3 files changed

Lines changed: 19 additions & 2 deletions

File tree

.werks/19850.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
[//]: # (werk v3)
2+
# Cisco Meraki: fix host label name for switch ports statuses
3+
4+
key | value
5+
---------- | ---
6+
date | 2026-04-22T13:12:31.851713+00:00
7+
version | 2.6.0b1
8+
class | fix
9+
edition | community
10+
component | checks
11+
level | 1
12+
compatible | no
13+
14+
The wrong name was set for the host label name in the Switch Ports Statuses
15+
plugin. It was set to `cmk/meraki/has_lldp_neighbors`, but is not correctly set
16+
to `cmk/has_lldp_neighbors` to match our general network topology functionality.
17+
To get the updated host label, you will need to re-run service discovery.

cmk/plugins/cisco_meraki/agent_based/cisco_meraki_org_switch_ports_statuses.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def host_label_meraki_switch_ports_statuses(section: Section) -> HostLabelGenera
205205
# NOTE: only setting LLDP label as Meraki CDP data are not useful for NVDCT.
206206
for port in section.values():
207207
if port.lldp:
208-
yield HostLabel(name="cmk/meraki/has_lldp_neighbors", value="yes")
208+
yield HostLabel(name="cmk/has_lldp_neighbors", value="yes")
209209

210210

211211
agent_section_cisco_meraki_org_switch_ports_statuses = AgentSection(

tests/unit/cmk/plugins/cisco_meraki/agent_based/test_cisco_meraki_org_switch_ports_statuses.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def test_with_lldp(self) -> None:
115115
section = self._build_section(with_lldp=True)
116116

117117
value = list(host_label_meraki_switch_ports_statuses(section))
118-
expected = [HostLabel("cmk/meraki/has_lldp_neighbors", "yes")]
118+
expected = [HostLabel("cmk/has_lldp_neighbors", "yes")]
119119

120120
assert value == expected
121121

0 commit comments

Comments
 (0)