Parse quantity tests - #23
Merged
Merged
Conversation
DavidGerva
commented
Jul 29, 2026
DavidGerva
commented
Collaborator
- handling some missing units in parse_quantity
- add test cases
DavidGerva
force-pushed
the
parse-quantity-improve
branch
from
July 29, 2026 08:55
81b0d33 to
b45f2ed
Compare
relrod
approved these changes
Jul 29, 2026
relrod
left a comment
relrod
left a comment
Member
There was a problem hiding this comment.
Approved and you can merge. A few missing edge cases inline if you want to be thorough, but up to you.
DavidGerva
force-pushed
the
parse-quantity-improve
branch
from
August 4, 2026 12:00
b45f2ed to
51605cf
Compare
DavidGerva
commented
Aug 4, 2026
DavidGerva
left a comment
DavidGerva
left a comment
Collaborator
Author
There was a problem hiding this comment.
Comments addressed!
relrod
approved these changes
Aug 4, 2026
add these missing parsed units: - "u", 1e-6 - "n", 1e-9
DavidGerva
force-pushed
the
parse-quantity-improve
branch
from
August 4, 2026 12:50
51605cf to
37e9661
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.