metrics-cache: make push interval configurable - #25
Merged
Conversation
DavidGerva
commented
Aug 7, 2026
DavidGerva
commented
Collaborator
- new CLI arg
- use thread the arg through to the push loop where 60s is currently hardcoded
- make it configurable via the helm chart
relrod
approved these changes
Aug 10, 2026
| #[test] | ||
| fn push_interval_cannot_be_zero() { | ||
| assert_eq!( | ||
| parse(&["--push-interval", "0"]) |
Member
There was a problem hiding this comment.
Maybe also a test for a negative value, though if someone passes a negative value they might deserve whatever they get 🤣
You'd probably have to test "--push-interval=-1" or similar, otherwise -1 will be parsed as a separate flag.
DavidGerva
enabled auto-merge (rebase)
August 11, 2026 07:59
DavidGerva
disabled auto-merge
August 11, 2026 07:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.