section: Add kube_node_info_v1 - #26
Open
bx9001 wants to merge 3 commits into
Open
Conversation
bx9001
marked this pull request as ready for review
August 10, 2026 10:30
bx9001
force-pushed
the
CMK-36235-node-info
branch
from
August 10, 2026 11:31
80e4447 to
6beb824
Compare
bx9001
force-pushed
the
CMK-36235-node-info
branch
from
August 12, 2026 07:57
6beb824 to
49f8ee3
Compare
relrod
approved these changes
Aug 12, 2026
relrod
left a comment
relrod
left a comment
Member
There was a problem hiding this comment.
Two nits inline (and one small separate followup request as another PR). Feel free to merge once the two nits are addressed.
Comment on lines
+7
to
+10
| use crate::section::{ | ||
| node::KubeNodeInfoV1, | ||
| writeable::{SectionError, WriteableSection}, | ||
| }; |
Member
There was a problem hiding this comment.
By convention with the rest of the project, prefer to only group leaves of import trees:
Suggested change
| use crate::section::{ | |
| node::KubeNodeInfoV1, | |
| writeable::{SectionError, WriteableSection}, | |
| }; | |
| use crate::section::node::KubeNodeInfoV1; | |
| use crate::section::writeable::{SectionError, WriteableSection}; |
But I know there are a few places lingering in the repo that break the convention.
(This would be nice to enforce with rustfmt but it's a nightly-only feature 😕)
| let mut out = Vec::new(); | ||
| if let Some(kube_node_info_v1) = KubeNodeInfoV1::from_node(self.api, self.settings) { | ||
| out.push(WriteableSection::of(&me, &kube_node_info_v1)); | ||
| }; |
Member
There was a problem hiding this comment.
Stray semicolon here
Suggested change
| }; | |
| } |
We have a few others in the repo, too, I just checked. Feel free to add this to Cargo.toml in the clippy section (as another PR) and fix the existing few occurrences, I'd appreciate it:
unnecessary_semicolon = "deny"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMK-36235