Cmk 36785 - #29
Open
DavidGerva wants to merge 2 commits into
Open
Conversation
DavidGerva
commented
Aug 11, 2026
| .expect_err("push interval of -1 should fail") | ||
| .kind(), | ||
| ErrorKind::ValueValidation | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Addressing your comment from the last PR
DavidGerva
commented
Aug 11, 2026
| - --push-registration-insecure-skip-site-ca-verification | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- if .Values.otel.enabled }} |
Collaborator
Author
There was a problem hiding this comment.
Following the logic from push mode
DavidGerva
commented
Aug 11, 2026
| # container-level metrics derived from the kubelet data, using OTLP over HTTP. | ||
| otel: | ||
| # enabled controls whether the OpenTelemetry export is activated or not. | ||
| enabled: false |
DavidGerva
marked this pull request as ready for review
August 11, 2026 13:32
relrod
reviewed
Aug 11, 2026
|
|
||
| #[test] | ||
| fn push_interval_cannot_be_zero() { | ||
| fn otel_push_interval_cannot_be_less_than_one() { |
Member
There was a problem hiding this comment.
this isn't testing --otel-push-interval so I don't think the rename is right
| .expect_err("push interval of -1 should fail") | ||
| .kind(), | ||
| ErrorKind::ValueValidation | ||
| ); |
|
|
||
| /// Push interval in seconds for sending otel metrics. | ||
| #[arg( | ||
| long = "otel-push-interval", |
Member
There was a problem hiding this comment.
I recently discovered, you don't need to specify the value to long if it can be derived from the name of the field. If you just specify long (without the = "otel-push-interval") it will default to the correct thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.