Basic .csmrc parsing - #4
Merged
Merged
Conversation
relrod
force-pushed
the
csmrc
branch
2 times, most recently
from
October 29, 2025 14:09
f8c15f8 to
4f49f8c
Compare
We rely here on `serde_yaml_ng`, which is a fork of `serde_yaml` that seems at least somewhat actively maintained and used. The benefit here is that we get easy deserialization into Rust types (which we wouldn't get with something like `yaml_rust2` which just gives an AST). The disadvantage is that we're depending on a library that I wish had more community backing like the original `serde_yaml` did. The alternative here would probably be foregoing YAML entirely and using TOML instead, but it seems the rest of the Robotmk ecosystem uses YAML, so it is probably best to remain consistent here.
Collaborator
Agreed. Given the constraint to use YAML, this seems fine to me. |
jherbel
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We rely here on
serde_yaml_ng, which is a fork ofserde_yamlthatseems at least somewhat actively maintained and used. The benefit here
is that we get easy deserialization into Rust types (which we wouldn't
get with something like
yaml_rust2which just gives an AST). Thedisadvantage is that we're depending on a library that I wish had more
community backing like the original
serde_yamldid.The alternative here would probably be foregoing YAML entirely and using
TOML instead, but it seems the rest of the Robotmk ecosystem uses YAML,
so it is probably best to remain consistent here.