Fix SourceReader.ungetc - #83
Open
hilman2 wants to merge 1 commit into
Open
Conversation
The guard reads `if not self.atStart(): raise`, so the method raised whenever there was a character to unget. At position 0 it fell through instead and set self._pos to -1. Writing the character back did `self._src[self._pos] = c`, an item assignment on a str. That is a TypeError on any Python 3, so the method could not succeed under any input. Nothing in Cheetah calls it; it is public API. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ungetccannot succeed under any input on master.The guard is inverted, so the method raises whenever there is a character to unget. At position 0 it falls through and sets
self._pos = -1, and the followingself._src[self._pos] = cis an item assignment on a str.Nothing in Cheetah calls it, so this is public API only. Three tests in
Tests/Misc.py. Full suite passes on 2.7, 3.6 and 3.12, flake8 clean.