Close the traceback cache file - #86
Open
hilman2 wants to merge 1 commit into
Open
Conversation
`open(__file__, 'w').write(generatedModuleCode)` leaves the file object open. CPython closes it by refcount soon after, with a ResourceWarning; on PyPy the file can be left empty or truncated, which defeats the feature it implements. The call also sits in a try whose finally releases _CHEETAH_compileLock, so a write failure released the lock and left a partial file behind. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open(__file__, 'w').write(generatedModuleCode)inTemplate.compileleaves the file object open. CPython closes it by refcount and emits a ResourceWarning; on PyPy the file can be left empty or truncated, which defeats the feature it implements.The call sits in a
trywhosefinallyreleases_CHEETAH_compileLock, so a write failure released the lock and left a partial file behind.CPython's refcounting hides this, so the test in
Tests/Template.pycovers that the file is written completely rather than reproducing the leak. Full suite passes on 2.7, 3.6 and 3.12, flake8 clean.