Skip to content

[Feat] expand coverage for patch and mailbox workflows#6

Closed
ChenMiaoi wants to merge 2 commits intodevelopfrom
experimental-dev
Closed

[Feat] expand coverage for patch and mailbox workflows#6
ChenMiaoi wants to merge 2 commits intodevelopfrom
experimental-dev

Conversation

@ChenMiaoi
Copy link
Owner

Summary

  • add IMAP doctor probing and archive sync behavior covered by the new tests
  • extend patch, sendmail, and TUI regression coverage across mailbox workflows
  • harden temporary command execution against transient executable-busy failures

Related Issues

Link issues if applicable.

  • Closes #
  • Related to #

What Changed

  • Added doctor and sync-path coverage for IMAP configuration handling, connection probing, and summary/report rendering.
  • Expanded lore.kernel.org and GNU archive sync support with tests for incremental fetches, feed/index parsing, raw mail retrieval, and proxy or transport failures.
  • Strengthened patch workflow coverage around series indexing, apply/download persistence, conflict reporting, and no-op apply detection.
  • Extended reply and TUI regression coverage for command palette behavior, search interactions, reply editing and preview flows, and mailbox navigation state transitions.
  • Hardened temporary command execution in b4 and git send-email paths by tolerating transient ExecutableFileBusy failures and stabilizing test fixture scripts.

Testing

List what you ran locally.

test result: ok. 298 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.18s

Documentation

  • No documentation change needed
  • README updated
  • Config / workflow docs updated
  • Other docs updated

Checklist

  • The change is focused on one topic
  • Commit messages follow the repository convention
  • Tests were added or updated when needed
  • User-visible behavior was documented when needed
  • I checked for regressions in related workflows

Notes For Reviewers

Anything that needs special attention during review.

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 97.35995% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/infra/imap.rs 96.76% 37 Missing ⚠️
src/app/mod.rs 93.69% 23 Missing ⚠️
src/infra/b4.rs 94.11% 13 Missing ⚠️
src/infra/sendmail.rs 96.33% 8 Missing ⚠️
src/infra/b4_vendor.rs 97.22% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ChenMiaoi
Copy link
Owner Author

@codex

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zevorn
Copy link
Contributor

zevorn commented Mar 9, 2026

@codex

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5108dba52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ChenMiaoi
Copy link
Owner Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- add IMAP doctor probing and archive sync behavior covered by the new tests
- extend patch, sendmail, and TUI regression coverage across mailbox workflows
- harden temporary command execution against transient executable-busy failures

Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Signed-off-by: Chen Miao <chenmiao.ku@gmail.com>
Copy link
Owner Author

@ChenMiaoi ChenMiaoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenMiaoi ChenMiaoi closed this Mar 9, 2026
@ChenMiaoi ChenMiaoi reopened this Mar 9, 2026
Copy link

@w1m024 w1m024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenMiaoi ChenMiaoi closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants